mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "schuster.simon@siemens-energy.com" <schuster.simon@siemens-energy.com>
Cc: "Dinh Nguyen" <dinguyen@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Sasha Levin" <sashal@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] lib: Add software mul/div helpers and use them from nios2
Date: Mon, 02 Nov 2026 08:42:42 +0100	[thread overview]
Message-ID: <7b84c967-43f3-4aa5-827f-93303814d759@app.fastmail.com> (raw)
In-Reply-To: <20261102064830.slncwl4e7x5qhhrt@dev-vm-schuster>

On Mon, Nov 2, 2026, at 07:48, Simon Schuster wrote:
>
> thank you for your comments!
>
> On Fri, Oct 30, 2026 at 05:50:58PM +0100, Arnd Bergmann wrote:
>> Just a few minor things that stood out:
>> 
>> - I don't see a need to add the files under arch/ first and then
>>   move them to lib/, just start with the added files there
>
> This is an artifact of (1) not wanting to touch or drop Dinh's patch
> after picking it up and (2) being quite contend with someone with a
> current Altera affiliation doing the initial Sign-off on that check in,
> (even though this is, of course, not strictly required by license); if
> you don't mind to much, I'd prefer to leave it that way?

I think it would be ideal if you adapt Dinh's patch to just add
the files into lib/ instead of arch/nios2/: the Signoff is for
the content of the files regardless of the location.

If you still want to keep it as two patches, we can of course work
with that as well, it just makes the git history a little confusing.

      Arnd

      reply	other threads:[~2026-11-02  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 15:53 Simon Schuster
2026-10-30 15:53 ` [PATCH 1/3] nios2: remove usage of libgcc Simon Schuster
2026-10-30 15:53 ` [PATCH 2/3] nios2: export __divsi3_table Simon Schuster
2026-10-30 15:53 ` [PATCH 3/3] lib: extract 32bit mul/div helpers from nios2 into GENERIC_LIB Simon Schuster
2026-10-30 16:50 ` [PATCH 0/3] lib: Add software mul/div helpers and use them from nios2 Arnd Bergmann
2026-11-02  6:48   ` Simon Schuster
2026-11-02  7:42     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b84c967-43f3-4aa5-827f-93303814d759@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=dinguyen@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=schuster.simon@siemens-energy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®