From: Jaakko Koivisto <jmatko@utu.fi>
To: "Andreas Klinger" <ak@it-klinger.de>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jaakko Koivisto <jmatko@utu.fi>
Subject: [PATCH v2 1/5] iio: chemical: sgp40: Do not convert I2C errors to EIO
Date: Mon, 2 Nov 2026 11:12:54 +0200 [thread overview]
Message-ID: <20261102091258.247402-2-jmatko@utu.fi> (raw)
In-Reply-To: <20261102091258.247402-1-jmatko@utu.fi>
Any negative error returned by i2c_master_send() in
sgp40_measure_resistance_raw() was caught by the
branch guarding against short sends, and the error
was subsequently replaced with -EIO.
Check for any negative errors first and propagate
the error without conversion.
Fixes: 1081b9d97152 ("iio: chemical: Add driver support for sgp40")
Signed-off-by: Jaakko Koivisto <jmatko@utu.fi>
---
Tested by forcing i2c clock to ground. The resulting ETIMEDOUT and
EREMOTEIO are now correctly communicated to userspace instead of
converting to EIO.
drivers/iio/chemical/sgp40.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/chemical/sgp40.c b/drivers/iio/chemical/sgp40.c
index b2b5e32a9eb2..3a239fb6847f 100644
--- a/drivers/iio/chemical/sgp40.c
+++ b/drivers/iio/chemical/sgp40.c
@@ -187,6 +187,8 @@ static int sgp40_measure_resistance_raw(struct sgp40_data *data, u16 *resistance
mutex_unlock(&data->lock);
ret = i2c_master_send(client, (const char *)&tg, sizeof(tg));
+ if (ret < 0)
+ return ret;
if (ret != sizeof(tg)) {
dev_warn(data->dev, "i2c_master_send ret: %d sizeof: %zu\n", ret, sizeof(tg));
return -EIO;
--
2.56.0
next prev parent reply other threads:[~2026-11-02 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 9:12 [PATCH v2 0/5] iio: chemical: sgp40: add funtions for serial number readback, self-test, and heater control Jaakko Koivisto
2026-11-02 9:12 ` Jaakko Koivisto [this message]
2026-11-02 9:54 ` [PATCH v2 1/5] iio: chemical: sgp40: Do not convert I2C errors to EIO Joshua Crofts
2026-11-02 9:12 ` [PATCH v2 2/5] iio: chemical: sgp40: Replace manual locking with guard() Jaakko Koivisto
2026-11-02 10:10 ` Joshua Crofts
2026-11-02 9:12 ` [PATCH v2 3/5] iio: chemical: sgp40: Implement get_serial_number-command Jaakko Koivisto
2026-11-02 10:20 ` Joshua Crofts
2026-11-02 9:12 ` [PATCH v2 4/5] iio: chemical: sgp40: Implement execute_self_test-command Jaakko Koivisto
2026-11-02 10:21 ` Joshua Crofts
2026-11-02 9:56 ` [PATCH v2 5/5] iio: chemical: sgp40: Implement turn_heater_off-command Jaakko Koivisto
2026-11-02 10:24 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102091258.247402-2-jmatko@utu.fi \
--to=jmatko@utu.fi \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®