From: Joshua Crofts <crofts@kernel.org>
To: Jaakko Koivisto <jmatko@utu.fi>
Cc: "Andreas Klinger" <ak@it-klinger.de>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] iio: chemical: sgp40: Implement turn_heater_off-command
Date: Mon, 2 Nov 2026 11:24:59 +0100 [thread overview]
Message-ID: <20261102112459.00001dc7@kernel.org> (raw)
In-Reply-To: <20261102095602.333752-1-jmatko@utu.fi>
On Mon, 2 Nov 2026 11:56:02 +0200
Jaakko Koivisto <jmatko@utu.fi> wrote:
...
> +static int sgp40_turn_heater_off(struct sgp40_data *data)
> +{
> + int ret;
> + struct i2c_client *client = data->client;
> + struct sgp40_tg_measure turn_off = { .command = {0x36, 0x15} };
Reverse xmas tree.
> +
> + guard(mutex)(&data->lock);
> +
> + ret = i2c_master_send(client, (char *)&turn_off, sizeof(turn_off.command));
> + if (ret < 0)
> + return ret;
> + if (ret != sizeof(turn_off.command))
> + return dev_err_probe(data->dev, -EIO,
> + "i2c_master_send ret: %d, expected %zu", ret, sizeof(turn_off.command));
Again, this function isn't called from probe(), yet it uses
dev_err_probe().
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-11-02 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 9:12 [PATCH v2 0/5] iio: chemical: sgp40: add funtions for serial number readback, self-test, and heater control Jaakko Koivisto
2026-11-02 9:12 ` [PATCH v2 1/5] iio: chemical: sgp40: Do not convert I2C errors to EIO Jaakko Koivisto
2026-11-02 9:54 ` Joshua Crofts
2026-11-02 9:12 ` [PATCH v2 2/5] iio: chemical: sgp40: Replace manual locking with guard() Jaakko Koivisto
2026-11-02 10:10 ` Joshua Crofts
2026-11-02 9:12 ` [PATCH v2 3/5] iio: chemical: sgp40: Implement get_serial_number-command Jaakko Koivisto
2026-11-02 10:20 ` Joshua Crofts
2026-11-02 9:12 ` [PATCH v2 4/5] iio: chemical: sgp40: Implement execute_self_test-command Jaakko Koivisto
2026-11-02 10:21 ` Joshua Crofts
2026-11-02 9:56 ` [PATCH v2 5/5] iio: chemical: sgp40: Implement turn_heater_off-command Jaakko Koivisto
2026-11-02 10:24 ` Joshua Crofts [this message]
2026-11-02 9:15 Jaakko Koivisto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102112459.00001dc7@kernel.org \
--to=crofts@kernel.org \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jmatko@utu.fi \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®