[PATCH 1/1] ata: use dmaengine_desc_set_callback()

[PATCH 1/1] ata: use dmaengine_desc_set_callback()

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Replace open-coded assignments to callback and callback_param fields
of struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper.

No functional change intended. Prepare make to struct
dma_async_tx_descriptor private to the DMA engine.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/ata/pata_arasan_cf.c | 3 +--
 drivers/ata/pata_ep93xx.c    | 3 +--
 drivers/ata/pata_pxa.c       | 3 +--
 drivers/ata/sata_dwc_460ex.c | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index a652a1b57338c..5bdfe46182472 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -406,8 +406,7 @@ dma_xfer(struct arasan_cf_dev *acdev, dma_addr_t src, dma_addr_t dest, u32 len)
 		return -EAGAIN;
 	}
 
-	tx->callback = dma_callback;
-	tx->callback_param = acdev;
+	dmaengine_desc_set_callback(tx, dma_callback, NULL, acdev);
 	cookie = dmaengine_submit(tx);
 
 	ret = dma_submit_error(cookie);
diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
index 339ee5e43e9f3..9371c7499b208 100644
--- a/drivers/ata/pata_ep93xx.c
+++ b/drivers/ata/pata_ep93xx.c
@@ -727,8 +727,7 @@ static void ep93xx_pata_dma_start(struct ata_queued_cmd *qc)
 		dev_err(qc->ap->dev, "failed to prepare slave for sg dma\n");
 		return;
 	}
-	txd->callback = NULL;
-	txd->callback_param = NULL;
+	dmaengine_desc_set_callback(txd, NULL, NULL, NULL);
 
 	if (dmaengine_submit(txd) < 0) {
 		dev_err(qc->ap->dev, "failed to submit dma transfer\n");
diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
index a694f6a178e31..04bba37c583bd 100644
--- a/drivers/ata/pata_pxa.c
+++ b/drivers/ata/pata_pxa.c
@@ -60,8 +60,7 @@ static enum ata_completion_errors pxa_qc_prep(struct ata_queued_cmd *qc)
 		ata_dev_err(qc->dev, "prep_slave_sg() failed\n");
 		return AC_ERR_OK;
 	}
-	tx->callback = pxa_ata_dma_irq;
-	tx->callback_param = pd;
+	dmaengine_desc_set_callback(tx, pxa_ata_dma_irq, NULL, pd);
 	pd->dma_cookie = dmaengine_submit(tx);
 
 	return AC_ERR_OK;
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index aa816a1a4c541..93a7651ec672d 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -347,8 +347,7 @@ static struct dma_async_tx_descriptor *dma_dwc_xfer_setup(struct ata_queued_cmd
 	if (!desc)
 		return NULL;
 
-	desc->callback = dma_dwc_xfer_done;
-	desc->callback_param = hsdev;
+	dmaengine_desc_set_callback(desc, dma_dwc_xfer_done, NULL, hsdev);
 
 	dev_dbg(hsdev->dev, "%s sg: 0x%p, count: %d addr: %pa\n", __func__,
 		qc->sg, qc->n_elem, &hsdev->dmadr);
-- 
2.43.0