mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] slimbus: use dmaengine_desc_set_callback()
@ 2026-11-02 17:48 Frank.Li
  0 siblings, 0 replies; only message in thread
From: Frank.Li @ 2026-11-02 17:48 UTC (permalink / raw)
  To: Srinivas Kandagatla, open list:ARM/QUALCOMM MAILING LIST,
	open list:SERIAL LOW-POWER INTER-CHIP MEDIA BUS (SLIMbus),
	open list
  Cc: imx, vkoul, Frank Li

From: Frank Li <Frank.Li@nxp.com>

Replace open-coded assignments to callback and callback_param fields
of struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper.

No functional change intended. Prepare make to struct
dma_async_tx_descriptor private to the DMA engine.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/slimbus/qcom-ngd-ctrl.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index eb983b6d1815f..539c8a6493969 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -595,8 +595,7 @@ static int qcom_slim_ngd_tx_msg_post(struct qcom_slim_ngd_ctrl *ctrl,
 		return -EINVAL;
 	}
 
-	desc->desc->callback = qcom_slim_ngd_tx_msg_dma_cb;
-	desc->desc->callback_param = desc;
+	dmaengine_desc_set_callback(desc->desc, qcom_slim_ngd_tx_msg_dma_cb, NULL, desc);
 	desc->desc->cookie = dmaengine_submit(desc->desc);
 	dma_async_issue_pending(ctrl->dma_tx_channel);
 	spin_unlock_irqrestore(&ctrl->tx_buf_lock, flags);
@@ -642,8 +641,7 @@ static void qcom_slim_ngd_rx_msgq_cb(void *args)
 		return;
 	}
 
-	desc->desc->callback = qcom_slim_ngd_rx_msgq_cb;
-	desc->desc->callback_param = desc;
+	dmaengine_desc_set_callback(desc->desc, qcom_slim_ngd_rx_msgq_cb, NULL, desc);
 	desc->desc->cookie = dmaengine_submit(desc->desc);
 	dma_async_issue_pending(ctrl->dma_rx_channel);
 }
@@ -667,8 +665,7 @@ static int qcom_slim_ngd_post_rx_msgq(struct qcom_slim_ngd_ctrl *ctrl)
 			return -EINVAL;
 		}
 
-		desc->desc->callback = qcom_slim_ngd_rx_msgq_cb;
-		desc->desc->callback_param = desc;
+		dmaengine_desc_set_callback(desc->desc, qcom_slim_ngd_rx_msgq_cb, NULL, desc);
 		desc->desc->cookie = dmaengine_submit(desc->desc);
 	}
 	dma_async_issue_pending(ctrl->dma_rx_channel);
-- 
2.43.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-02 17:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-02 17:48 [PATCH 1/1] slimbus: use dmaengine_desc_set_callback() Frank.Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®