From: Frank.Li@oss.nxp.com
To: "Manivannan Sadhasivam" <mani@kernel.org>,
"Jeff Hugo" <jeff.hugo@oss.qualcomm.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Frank Li" <Frank.Li@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
mhi@lists.linux.dev (open list:MHI BUS),
linux-arm-msm@vger.kernel.org (open list:MHI BUS),
linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev, vkoul@kernel.org, Frank Li <Frank.Li@nxp.com>
Subject: [PATCH 1/1] PCI: epf-mhi: use dmaengine_desc_set_callback()
Date: Mon, 2 Nov 2026 14:55:33 -0500 [thread overview]
Message-ID: <20261102195534.4088523-1-Frank.Li@oss.nxp.com> (raw)
From: Frank Li <Frank.Li@nxp.com>
Replace open-coded assignments to callback and callback_param fields of
struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper.
No functional change intended. Prepare to make struct
dma_async_tx_descriptor private to the DMA engine.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/pci/endpoint/functions/pci-epf-mhi.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
index 78f1fb1a6b0c7..a63c50d235d6e 100644
--- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
+++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
@@ -346,8 +346,8 @@ static int pci_epf_mhi_edma_read(struct mhi_ep_cntrl *mhi_cntrl,
goto err_unmap;
}
- desc->callback = pci_epf_mhi_dma_callback;
- desc->callback_param = &complete;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_callback, NULL,
+ &complete);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
@@ -414,8 +414,8 @@ static int pci_epf_mhi_edma_write(struct mhi_ep_cntrl *mhi_cntrl,
goto err_unmap;
}
- desc->callback = pci_epf_mhi_dma_callback;
- desc->callback_param = &complete;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_callback, NULL,
+ &complete);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
@@ -526,8 +526,8 @@ static int pci_epf_mhi_edma_read_async(struct mhi_ep_cntrl *mhi_cntrl,
transfer->dir = DMA_FROM_DEVICE;
memcpy(&transfer->buf_info, buf_info, sizeof(*buf_info));
- desc->callback = pci_epf_mhi_dma_async_callback;
- desc->callback_param = transfer;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_async_callback, NULL,
+ transfer);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
@@ -600,8 +600,8 @@ static int pci_epf_mhi_edma_write_async(struct mhi_ep_cntrl *mhi_cntrl,
transfer->dir = DMA_TO_DEVICE;
memcpy(&transfer->buf_info, buf_info, sizeof(*buf_info));
- desc->callback = pci_epf_mhi_dma_async_callback;
- desc->callback_param = transfer;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_async_callback, NULL,
+ transfer);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
--
2.43.0
reply other threads:[~2026-11-02 19:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102195534.4088523-1-Frank.Li@oss.nxp.com \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=imx@lists.linux.dev \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®