mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] PCI: epf-mhi: use dmaengine_desc_set_callback()
@ 2026-11-02 19:55 Frank.Li
  0 siblings, 0 replies; only message in thread
From: Frank.Li @ 2026-11-02 19:55 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Jeff Hugo, Krzysztof Wilczyński,
	Kishon Vijay Abraham I, Frank Li, Bjorn Helgaas,
	open list:MHI BUS, open list:MHI BUS,
	open list:PCI ENDPOINT SUBSYSTEM, open list
  Cc: imx, vkoul, Frank Li

From: Frank Li <Frank.Li@nxp.com>

Replace open-coded assignments to callback and callback_param fields of
struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper.

No functional change intended. Prepare to make struct
dma_async_tx_descriptor private to the DMA engine.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/pci/endpoint/functions/pci-epf-mhi.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
index 78f1fb1a6b0c7..a63c50d235d6e 100644
--- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
+++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
@@ -346,8 +346,8 @@ static int pci_epf_mhi_edma_read(struct mhi_ep_cntrl *mhi_cntrl,
 		goto err_unmap;
 	}
 
-	desc->callback = pci_epf_mhi_dma_callback;
-	desc->callback_param = &complete;
+	dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_callback, NULL,
+				    &complete);
 
 	cookie = dmaengine_submit(desc);
 	ret = dma_submit_error(cookie);
@@ -414,8 +414,8 @@ static int pci_epf_mhi_edma_write(struct mhi_ep_cntrl *mhi_cntrl,
 		goto err_unmap;
 	}
 
-	desc->callback = pci_epf_mhi_dma_callback;
-	desc->callback_param = &complete;
+	dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_callback, NULL,
+				    &complete);
 
 	cookie = dmaengine_submit(desc);
 	ret = dma_submit_error(cookie);
@@ -526,8 +526,8 @@ static int pci_epf_mhi_edma_read_async(struct mhi_ep_cntrl *mhi_cntrl,
 	transfer->dir = DMA_FROM_DEVICE;
 	memcpy(&transfer->buf_info, buf_info, sizeof(*buf_info));
 
-	desc->callback = pci_epf_mhi_dma_async_callback;
-	desc->callback_param = transfer;
+	dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_async_callback, NULL,
+				    transfer);
 
 	cookie = dmaengine_submit(desc);
 	ret = dma_submit_error(cookie);
@@ -600,8 +600,8 @@ static int pci_epf_mhi_edma_write_async(struct mhi_ep_cntrl *mhi_cntrl,
 	transfer->dir = DMA_TO_DEVICE;
 	memcpy(&transfer->buf_info, buf_info, sizeof(*buf_info));
 
-	desc->callback = pci_epf_mhi_dma_async_callback;
-	desc->callback_param = transfer;
+	dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_async_callback, NULL,
+				    transfer);
 
 	cookie = dmaengine_submit(desc);
 	ret = dma_submit_error(cookie);
-- 
2.43.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-02 19:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-02 19:55 [PATCH 1/1] PCI: epf-mhi: use dmaengine_desc_set_callback() Frank.Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®