[PATCH] media: radio-isa: Unregister v4l2 device on probe failure

[PATCH] media: radio-isa: Unregister v4l2 device on probe failure

[Wentao Liang]

radio_isa_common_probe() registers the v4l2 device with
v4l2_device_register(), which takes a reference on the parent device. If
creating the controls, calling the driver's init callback, setting up the
controls or registering the video device fails, the error path frees the
control handler, releases the I/O region and frees the card, but never
calls v4l2_device_unregister(). The reference on the parent device is
leaked, and radio_isa_common_remove() does not run after a failed probe
to release it later.

Unregister the v4l2 device in the error path before releasing the I/O
region.

Fixes: 137c579c12bb ("[media] radio-isa: add framework for ISA radio drivers")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/media/radio/radio-isa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/radio/radio-isa.c b/drivers/media/radio/radio-isa.c
index 1a144536ffa7..dc905c57e3e7 100644
--- a/drivers/media/radio/radio-isa.c
+++ b/drivers/media/radio/radio-isa.c
@@ -267,6 +267,7 @@ static int radio_isa_common_probe(struct radio_isa_card *isa,
 
 err_hdl:
 	v4l2_ctrl_handler_free(&isa->hdl);
+	v4l2_device_unregister(v4l2_dev);
 err_dev_reg:
 	release_region(isa->io, region_size);
 	kfree(isa);
-- 
2.34.1

Re: [PATCH] media: radio-isa: Unregister v4l2 device on probe failure

[Krzysztof Kozlowski]

On Tue, 03 Nov 2026 09:46:18 +0000, Wentao Liang wrote:
> radio_isa_common_probe() registers the v4l2 device with
> v4l2_device_register(), which takes a reference on the parent device. If
> creating the controls, calling the driver's init callback, setting up the
> controls or registering the video device fails, the error path frees the
> control handler, releases the I/O region and frees the card, but never
> calls v4l2_device_unregister(). The reference on the parent device is
> leaked, and radio_isa_common_remove() does not run after a failed probe
> to release it later.
> 
> Unregister the v4l2 device in the error path before releasing the I/O
> region.
> 
> Fixes: 137c579c12bb ("[media] radio-isa: add framework for ISA radio drivers")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/media/radio/radio-isa.c | 1 +
>  1 file changed, 1 insertion(+)
> 



Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.

2. You use multiple identities with this email address, thus I doubt that we
   speak with an actual person.

3. Your bot does not even bother running checkpatch, right?

4. Nothing of this was reproduced nor tested.

5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.

Best regards,
Krzysztof