From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
rafael@kernel.org, stable@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: mediatek: Release DVFS resources when removing the driver
Date: Tue, 3 Nov 2026 08:27:13 +0100 [thread overview]
Message-ID: <20261103-fanatic-grumpy-elk-a1df5e@quoll> (raw)
In-Reply-To: <20261103063609.1028187-1-vulab@iscas.ac.cn>
On Tue, 03 Nov 2026 06:36:09 +0000, Wentao Liang wrote:
> mtk_cpufreq_probe() registers the cpufreq driver and retains clocks,
> regulators, OPP tables and OPP notifiers in dvfs_info_list. There is no
> platform remove callback to undo this on device unbind or module unload.
> The devm-allocated DVFS information is freed while the list and cpufreq
> driver still refer to it, in addition to leaking the retained resources.
>
> Unregister the cpufreq driver before releasing the DVFS resources and
> removing their entries from the list, as in the probe failure path.
>
> Fixes: 89b56047f6f9 ("cpufreq: mt8173: Move resources allocation into ->probe()")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.
2. You use multiple identities with this email, thus I doubt
that we speak with an actual person.
3. Your bot does not even bother running checkpatch, right?
4. Nothing of this was reproduced nor tested.
5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.
More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.
This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down. Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.
Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document usage of LLM and what you should not do
if this was posted in a good faith.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-11-03 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 6:36 Wentao Liang
2026-11-03 7:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103-fanatic-grumpy-elk-a1df5e@quoll \
--to=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®