From: Wentao Liang <vulab@iscas.ac.cn>
To: rafael@kernel.org, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] cpufreq: mediatek: Release DVFS resources when removing the driver
Date: Tue, 3 Nov 2026 06:36:09 +0000 [thread overview]
Message-ID: <20261103063609.1028187-1-vulab@iscas.ac.cn> (raw)
mtk_cpufreq_probe() registers the cpufreq driver and retains clocks,
regulators, OPP tables and OPP notifiers in dvfs_info_list. There is no
platform remove callback to undo this on device unbind or module unload.
The devm-allocated DVFS information is freed while the list and cpufreq
driver still refer to it, in addition to leaking the retained resources.
Unregister the cpufreq driver before releasing the DVFS resources and
removing their entries from the list, as in the probe failure path.
Fixes: 89b56047f6f9 ("cpufreq: mt8173: Move resources allocation into ->probe()")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/cpufreq/mediatek-cpufreq.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index f9b1eca176eb..5776310d96c0 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -677,11 +677,24 @@ static int mtk_cpufreq_probe(struct platform_device *pdev)
return ret;
}
+static void mtk_cpufreq_remove(struct platform_device *pdev)
+{
+ struct mtk_cpu_dvfs_info *info, *tmp;
+
+ cpufreq_unregister_driver(&mtk_cpufreq_driver);
+
+ list_for_each_entry_safe(info, tmp, &dvfs_info_list, list_head) {
+ mtk_cpu_dvfs_info_release(info);
+ list_del(&info->list_head);
+ }
+}
+
static struct platform_driver mtk_cpufreq_platdrv = {
.driver = {
.name = "mtk-cpufreq",
},
.probe = mtk_cpufreq_probe,
+ .remove = mtk_cpufreq_remove,
};
static const struct mtk_cpufreq_platform_data mt2701_platform_data = {
--
2.34.1
next reply other threads:[~2026-11-03 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 6:36 Wentao Liang [this message]
2026-11-03 7:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103063609.1028187-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®