From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stefan Agner <stefan@agner.ch>,
Dong Aisheng <aisheng.dong@nxp.com>,
Jacky Bai <ping.bai@nxp.com>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Peng Fan <peng.fan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: [PATCH v2 02/11] gpio: vf610: simplify with irq_set_irq_wake()
Date: Tue, 03 Nov 2026 07:44:06 +0800 [thread overview]
Message-ID: <20261103-gpio-vf610-fixes-v2-2-7c71fb36e184@nxp.com> (raw)
In-Reply-To: <20261103-gpio-vf610-fixes-v2-0-7c71fb36e184@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Replace the manual enable/disable irq wake logic with a single call to
irq_set_irq_wake() to simplify code.
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/gpio/gpio-vf610.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index adfa2c2d5873..c1c562071c0d 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -189,10 +189,7 @@ static int vf610_gpio_irq_set_wake(struct irq_data *d, u32 enable)
struct vf610_gpio_port *port =
gpiochip_get_data(irq_data_get_irq_chip_data(d));
- if (enable)
- enable_irq_wake(port->irq);
- else
- disable_irq_wake(port->irq);
+ irq_set_irq_wake(port->irq, enable);
return 0;
}
--
2.51.0
next prev parent reply other threads:[~2026-11-02 23:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 23:44 [PATCH v2 00/11] gpio: vf610: fix clocks and misc cleanup Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 01/11] dt-bindings: gpio: vf610: fix clock requirements per SoC Peng Fan (OSS)
2026-11-03 11:46 ` Krzysztof Kozlowski
2026-11-03 13:15 ` Peng Fan
2026-11-03 13:14 ` Krzysztof Kozlowski
2026-11-03 14:00 ` Peng Fan
2026-11-03 14:19 ` Krzysztof Kozlowski
2026-11-02 23:44 ` Peng Fan (OSS) [this message]
2026-11-02 23:44 ` [PATCH v2 03/11] gpio: vf610: use devm_clk_get_optional_enabled() for clock handling Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 04/11] gpio: vf610: drop unneeded header Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 05/11] gpio: vf610: drop unnecessary wrappers Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 06/11] MAINTAINERS: Update i.MX GPIO entry Peng Fan (OSS)
2026-11-03 11:47 ` Krzysztof Kozlowski
2026-11-02 23:44 ` [PATCH v2 07/11] arm64: dts: imx8ulp: fix gpio clocks Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 08/11] arm64: dts: imx93: " Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 09/11] arm64: dts: imx95: " Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 10/11] arm64: dts: imx952: " Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 11/11] arm64: dts: imx94: add clocks for gpio controller Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103-gpio-vf610-fixes-v2-2-7c71fb36e184@nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=brgl@bgdev.pl \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®