mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Stefan Agner <stefan@agner.ch>,
	Dong Aisheng <aisheng.dong@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
	Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2 01/11] dt-bindings: gpio: vf610: fix clock requirements per SoC
Date: Tue, 3 Nov 2026 21:15:55 +0800	[thread overview]
Message-ID: <auneixIA0ZtvXukt@shlinux89> (raw)
In-Reply-To: <20261103-venomous-hyena-of-fortitude-063eae@quoll>

On Tue, Nov 03, 2026 at 12:46:12PM +0100, Krzysztof Kozlowski wrote:
>On Tue, Nov 03, 2026 at 07:44:05AM +0800, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>> 
>> The i.MX7ULP GPIO controller needs both the GPIO and PORT clocks,
>> while the i.MX8ULP and its derivatives (i.MX93/94/95/952) only have
>> a single "gpio" clock. The VF610 controller has no gateable clocks,
>> so keep clocks optional there.
>
>Same second comment.

Please suggest what I should use to replace vf610 in the subject.
I not find a better idea expect picking "vf610" from the filename.

>
>> 
>> Describe the clock items with minItems/maxItems, require exactly two
>> clocks for i.MX7ULP, and require exactly one "gpio" clock for the
>> +    then:
>> +      properties:
>> +        clocks:
>> +          minItems: 2
>> +          maxItems: 2
>
>So you ignore not only my feedback... Good to know, the more the
>merrier.

Oops. Frank raised this.

Thanks
Peng

>
>Best regards,
>Krzysztof
>
>

  reply	other threads:[~2026-11-03 13:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 23:44 [PATCH v2 00/11] gpio: vf610: fix clocks and misc cleanup Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 01/11] dt-bindings: gpio: vf610: fix clock requirements per SoC Peng Fan (OSS)
2026-11-03 11:46   ` Krzysztof Kozlowski
2026-11-03 13:15     ` Peng Fan [this message]
2026-11-03 13:14       ` Krzysztof Kozlowski
2026-11-03 14:00         ` Peng Fan
2026-11-03 14:19           ` Krzysztof Kozlowski
2026-11-02 23:44 ` [PATCH v2 02/11] gpio: vf610: simplify with irq_set_irq_wake() Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 03/11] gpio: vf610: use devm_clk_get_optional_enabled() for clock handling Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 04/11] gpio: vf610: drop unneeded header Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 05/11] gpio: vf610: drop unnecessary wrappers Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 06/11] MAINTAINERS: Update i.MX GPIO entry Peng Fan (OSS)
2026-11-03 11:47   ` Krzysztof Kozlowski
2026-11-02 23:44 ` [PATCH v2 07/11] arm64: dts: imx8ulp: fix gpio clocks Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 08/11] arm64: dts: imx93: " Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 09/11] arm64: dts: imx95: " Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 10/11] arm64: dts: imx952: " Peng Fan (OSS)
2026-11-02 23:44 ` [PATCH v2 11/11] arm64: dts: imx94: add clocks for gpio controller Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auneixIA0ZtvXukt@shlinux89 \
    --to=peng.fan@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=brgl@bgdev.pl \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®