[PATCH] drm/nouveau: Remove the audio device link on component unbind

[PATCH] drm/nouveau: Remove the audio device link on component unbind

[Wentao Liang]

nv50_audio_component_bind() creates a stateless device link from the HDA
device to the GPU. Component unbind clears the audio component pointers
but never removes that link. Stateless links are reference counted and
must be explicitly released by their caller, so repeated component binds
retain a link reference on every cycle.

Remove the link after disconnecting the audio component in unbind. This
also covers a later failure of the HDA component master's bind callback.

Fixes: 742db30c4ee6 ("drm/nouveau: Add HD-audio component notifier support")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index e91130f93db6..bcfddb7008ac 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -672,6 +672,8 @@ nv50_audio_component_unbind(struct device *kdev, struct device *hda_kdev,
 	acomp->ops = NULL;
 	acomp->dev = NULL;
 	drm_modeset_unlock_all(drm->dev);
+
+	device_link_remove(hda_kdev, kdev);
 }
 
 static const struct component_ops nv50_audio_component_bind_ops = {
-- 
2.34.1

Re: [PATCH] drm/nouveau: Remove the audio device link on component unbind

[Krzysztof Kozlowski]

On Tue, 03 Nov 2026 07:03:31 +0000, Wentao Liang wrote:
> nv50_audio_component_bind() creates a stateless device link from the HDA
> device to the GPU. Component unbind clears the audio component pointers
> but never removes that link. Stateless links are reference counted and
> must be explicitly released by their caller, so repeated component binds
> retain a link reference on every cycle.
> 
> Remove the link after disconnecting the audio component in unbind. This
> also covers a later failure of the HDA component master's bind callback.
> 
> Fixes: 742db30c4ee6 ("drm/nouveau: Add HD-audio component notifier support")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 



Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.

2. You use multiple identities with this email, thus I doubt
   that we speak with an actual person.

3. Your bot does not even bother running checkpatch, right?

4. Nothing of this was reproduced nor tested.

5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document usage of LLM and what you should not do
if this was posted in a good faith.

Best regards,
Krzysztof