* [PATCH RESEND] bcache: Release the cache kobject when cache_alloc() fails
@ 2026-11-03 9:46 Wentao Liang
2026-11-03 10:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2026-11-03 9:46 UTC (permalink / raw)
To: Coly Li, Kent Overstreet; +Cc: linux-bcache, linux-kernel, Wentao Liang, stable
cache_alloc() initializes ca->kobj with kobject_init(), which takes the
initial reference on the kobject, and takes a reference on the bcache
module. The object is released later by bch_cache_release(), which also
drops the block device, puts the super block folio, frees ca and drops
the module reference.
When one of the allocations in cache_alloc() fails, the function frees
only the buffers it managed to allocate and returns an error.
register_cache() then only calls fput() on the block device and returns,
so the reference taken by kobject_init() is never dropped: ca is leaked
together with the super block folio and the module reference. The
comment on that path still claims that ca->kobj is not initialized, but
kobject_init() is the first thing cache_alloc() does.
Put ca->kobj on that path so that bch_cache_release() runs and releases
everything. bch_cache_release() frees ca->buckets and ca->prio_buckets
as well, so clear those pointers in cache_alloc() after freeing them, and
drop the module_put() from the error path because the module reference is
now released by bch_cache_release(). Skip the bucket page free in
bch_cache_release() when cache_alloc() failed before allocating them.
Fixes: cafe56359144 ("bcache: A block layer cache")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/md/bcache/super.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 97d9adb0bf96..5d4975873c2e 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -2221,7 +2221,9 @@ void bch_cache_release(struct kobject *kobj)
ca->set->cache = NULL;
}
- free_pages((unsigned long) ca->disk_buckets, ilog2(meta_bucket_pages(&ca->sb)));
+ if (ca->disk_buckets)
+ free_pages((unsigned long) ca->disk_buckets,
+ ilog2(meta_bucket_pages(&ca->sb)));
kfree(ca->prio_buckets);
vfree(ca->buckets);
@@ -2364,8 +2366,10 @@ static int cache_alloc(struct cache *ca)
err_disk_buckets_alloc:
kfree(ca->prio_buckets);
+ ca->prio_buckets = NULL;
err_prio_buckets_alloc:
vfree(ca->buckets);
+ ca->buckets = NULL;
err_buckets_alloc:
free_heap(&ca->heap);
err_heap_alloc:
@@ -2380,7 +2384,10 @@ static int cache_alloc(struct cache *ca)
free_fifo(&ca->free[RESERVE_BTREE]);
err_btree_alloc:
err_free:
- module_put(THIS_MODULE);
+ /*
+ * The module reference taken above is dropped by
+ * bch_cache_release() when the caller puts ca->kobj.
+ */
if (err)
pr_notice("error %pg: %s\n", ca->bdev, err);
return ret;
@@ -2408,13 +2415,12 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
err = "cache_alloc(): unknown error";
pr_notice("error %pg: %s\n", file_bdev(bdev_file), err);
/*
- * If we failed here, it means ca->kobj is not initialized yet,
- * kobject_put() won't be called and there is no chance to
- * call fput() to bdev in bch_cache_release(). So
- * we explicitly call fput() on the block device here.
+ * cache_alloc() has already released the buffers it
+ * allocated, so go through out: to drop the reference
+ * taken by kobject_init(); bch_cache_release() then frees
+ * ca and drops the block device and the super block folio.
*/
- fput(bdev_file);
- return ret;
+ goto out;
}
if (kobject_add(&ca->kobj, bdev_kobj(file_bdev(bdev_file)), "bcache")) {
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] bcache: Release the cache kobject when cache_alloc() fails
2026-11-03 9:46 [PATCH RESEND] bcache: Release the cache kobject when cache_alloc() fails Wentao Liang
@ 2026-11-03 10:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-03 10:26 UTC (permalink / raw)
To: Wentao Liang; +Cc: Coly Li, Kent Overstreet, linux-bcache, linux-kernel, stable
On Tue, 03 Nov 2026 09:46:43 +0000, Wentao Liang wrote:
> cache_alloc() initializes ca->kobj with kobject_init(), which takes the
> initial reference on the kobject, and takes a reference on the bcache
> module. The object is released later by bch_cache_release(), which also
> drops the block device, puts the super block folio, frees ca and drops
> the module reference.
>
> When one of the allocations in cache_alloc() fails, the function frees
> only the buffers it managed to allocate and returns an error.
> register_cache() then only calls fput() on the block device and returns,
> so the reference taken by kobject_init() is never dropped: ca is leaked
> together with the super block folio and the module reference. The
> comment on that path still claims that ca->kobj is not initialized, but
> kobject_init() is the first thing cache_alloc() does.
>
> Put ca->kobj on that path so that bch_cache_release() runs and releases
> everything. bch_cache_release() frees ca->buckets and ca->prio_buckets
> as well, so clear those pointers in cache_alloc() after freeing them, and
> drop the module_put() from the error path because the module reference is
> now released by bch_cache_release(). Skip the bucket page free in
> bch_cache_release() when cache_alloc() failed before allocating them.
>
> Fixes: cafe56359144 ("bcache: A block layer cache")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/md/bcache/super.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.
2. You use multiple identities with this email address, thus I doubt that we
speak with an actual person.
3. Your bot does not even bother running checkpatch, right?
4. Nothing of this was reproduced nor tested.
5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.
More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.
This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down. Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.
Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-03 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-03 9:46 [PATCH RESEND] bcache: Release the cache kobject when cache_alloc() fails Wentao Liang
2026-11-03 10:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®