* [PATCH v2] kernfs: fix stale comment referencing old @sd
@ 2026-11-03 4:25 Shuncai Tang
2026-11-03 9:31 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Shuncai Tang @ 2026-11-03 4:25 UTC (permalink / raw)
To: Greg Kroah-Hartman, Tejun Heo; +Cc: driver-core, linux-kernel, Shuncai Tang
The comment still refers to old @sd which was a sysfs_dirent.
Update it to @kn to match the current function argument.
No functional change.
v2: Use full name in Signed-off-by.
Signed-off-by: Shuncai Tang <jacktangsc@icloud.com>
---
fs/kernfs/kernfs-internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/kernfs/kernfs-internal.h b/fs/kernfs/kernfs-internal.h
index f1e93b09e..0fd8dea0b 100644
--- a/fs/kernfs/kernfs-internal.h
+++ b/fs/kernfs/kernfs-internal.h
@@ -72,7 +72,7 @@ struct kernfs_root {
static inline struct kernfs_root *kernfs_root(const struct kernfs_node *kn)
{
const struct kernfs_node *knp;
- /* if parent exists, it's always a dir; otherwise, @sd is a dir */
+ /* if parent exists, it's always a dir; otherwise, @kn is a dir */
guard(rcu)();
knp = rcu_dereference(kn->__parent);
if (knp)
--
2.50.1 (Apple Git-155)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] kernfs: fix stale comment referencing old @sd
2026-11-03 4:25 [PATCH v2] kernfs: fix stale comment referencing old @sd Shuncai Tang
@ 2026-11-03 9:31 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-11-03 9:31 UTC (permalink / raw)
To: Shuncai Tang; +Cc: Tejun Heo, driver-core, linux-kernel
On Tue, Nov 03, 2026 at 12:25:51PM +0800, Shuncai Tang wrote:
> The comment still refers to old @sd which was a sysfs_dirent.
> Update it to @kn to match the current function argument.
>
> No functional change.
>
> v2: Use full name in Signed-off-by.
This goes below the --- line, please read the documentation again for
how to do this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-03 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-03 4:25 [PATCH v2] kernfs: fix stale comment referencing old @sd Shuncai Tang
2026-11-03 9:31 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®