From: SJ Park <sj@kernel.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>
Cc: SJ Park <sj@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Aveline Noir <jm5905938@gmail.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Docs/admin-guide/mm/damon/reclaim: improve language
Date: Tue, 3 Nov 2026 07:05:28 -0800 [thread overview]
Message-ID: <20261103150528.88546-1-sj@kernel.org> (raw)
In-Reply-To: <20261103120043.100887-2-manuelebnerli@mailbox.org>
Hello Manuel,
On Tue, 3 Nov 2026 13:00:42 +0100 Manuel Ebner <manuelebnerli@mailbox.org> wrote:
> Fix upper case. Fix tenses. Replace 'set as' with 'set to'. Add space after
Please wrap lines for 75 chars per line, from the next time. Otherwise,
checkpatch.pl will warn like below:
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> sentence to make it double space. Rewrite and refine complex sentences.
>
> CC: Aveline Noir <jm5905938@gmail.com>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> That's the final version.
Thank you for revisioning.
[...]
> --- a/Documentation/admin-guide/mm/damon/reclaim.rst
> +++ b/Documentation/admin-guide/mm/damon/reclaim.rst
> @@ -4,7 +4,7 @@
> DAMON-based Reclamation
> =======================
>
> -DAMON-based Reclamation (DAMON_RECLAIM) is a static kernel module that aimed to
> +DAMON-based reclamation (DAMON_RECLAIM) is a static kernel module that aimes to
Sashiko suggested [1] s/aimes/aims/ ?
[...]
> @@ -88,7 +89,7 @@ identifies the region as cold, and reclaims it.
> autotune_monitoring_intervals
> -----------------------------
>
> -If this parameter is set as ``Y``, DAMON_RECLAIM automatically tunes DAMON's
> +If this parameter is set to ``Y``, DAMON_RECLAIM automatically tunes DAMON's
> sampling and aggregation intervals. The auto-tuning aims to capture meaningful
> amount of access events in each DAMON-snapshot, while keeping the sampling
> interval 5 milliseconds in minimum, and 10 seconds in maximum. Setting this as
Sashiko also suggested [1] to update above 'Setting this as' to 'Setting this
to'.
Other than above two,
Reviewed-by: SJ Park <sj@kernel.org>
Assuming you don't mind accepting above two Sashiko suggestions, I applied this
patch with the suggested changes to damon/next [1] tree. I will repost it soon
(~1 week) as an mm.git merge request. So, no action from your side is needed
for now.
[1] https://lore.kernel.org
[2] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-11-03 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 12:00 Manuel Ebner
2026-11-03 15:05 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103150528.88546-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=jm5905938@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manuelebnerli@mailbox.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®