* [PATCH] selftests/cgroup: read and write size_t with %zu in test_zswap
@ 2026-11-03 15:54 Sasha Levin
2026-11-03 16:17 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2026-11-03 15:54 UTC (permalink / raw)
To: Johannes Weiner, Yosry Ahmed, Nhat Pham, Tejun Heo, Michal Koutný
Cc: Chengming Zhou, Shuah Khan, linux-mm, cgroups, linux-kselftest,
linux-kernel
On 32-bit architectures size_t is an unsigned int, and reading and
writing it with %ld warns:
test_zswap.c:34:29: warning: format '%ld' expects argument of type 'long int *', but argument 3 has type 'size_t *' {aka 'unsigned int *'} [-Wformat=]
Use %zu.
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
Found with a 32-bit build of the selftests with a 64-bit time_t (gcc 16
and clang 21 with -m32 -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64);
KernelCI's 32-bit arm builds show the same warnings. The changed files
build without format warnings there now, and the x86_64 builds don't
change. The other selftests get the same kind of fix in separate
patches.
tools/testing/selftests/cgroup/test_zswap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
index d50acc1b83ac8..9b5769b417410 100644
--- a/tools/testing/selftests/cgroup/test_zswap.c
+++ b/tools/testing/selftests/cgroup/test_zswap.c
@@ -31,7 +31,7 @@ static int read_int(const char *path, size_t *value)
file = fopen(path, "r");
if (!file)
return -1;
- if (fscanf(file, "%ld", value) != 1)
+ if (fscanf(file, "%zu", value) != 1)
ret = -1;
fclose(file);
return ret;
@@ -45,7 +45,7 @@ static int set_min_free_kb(size_t value)
file = fopen("/proc/sys/vm/min_free_kbytes", "w");
if (!file)
return -1;
- ret = fprintf(file, "%ld\n", value);
+ ret = fprintf(file, "%zu\n", value);
fclose(file);
return ret;
}
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/cgroup: read and write size_t with %zu in test_zswap
2026-11-03 15:54 [PATCH] selftests/cgroup: read and write size_t with %zu in test_zswap Sasha Levin
@ 2026-11-03 16:17 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2026-11-03 16:17 UTC (permalink / raw)
To: Sasha Levin
Cc: Johannes Weiner, Yosry Ahmed, Nhat Pham, Michal Koutný,
Chengming Zhou, Shuah Khan, linux-mm, cgroups, linux-kselftest,
linux-kernel
Applied to cgroup/for-7.5.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-03 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-03 15:54 [PATCH] selftests/cgroup: read and write size_t with %zu in test_zswap Sasha Levin
2026-11-03 16:17 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®