[PATCH 1/1] ata: replace chan->device->dev with dmaengine_get_provider_device()

[PATCH 1/1] ata: replace chan->device->dev with dmaengine_get_provider_device()

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Use the dmaengine_get_provider_device() API instead of directly
accessing chan->device->dev to get the DMA provider device.

No functional change intended. Prepare make to struct dma_device private
to the DMA engine.

Assisted-by: LLM
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/ata/sata_dwc_460ex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index 93a7651ec672d..5bfad9a8c8162 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -192,7 +192,7 @@ static bool sata_dwc_dma_filter(struct dma_chan *chan, void *param)
 {
 	struct dw_dma_slave *dws = &sata_dwc_dma_dws;
 
-	if (dws->dma_dev != chan->device->dev)
+	if (dws->dma_dev != dmaengine_get_provider_device(chan))
 		return false;
 
 	chan->private = dws;
-- 
2.43.0

Re: [PATCH 1/1] ata: replace chan->device->dev with dmaengine_get_provider_device()

[Damien Le Moal]

On 11/4/26 06:24, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
> 
> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change intended. Prepare make to struct dma_device private
> to the DMA engine.
> 
> Assisted-by: LLM

Please drop this.

> Signed-off-by: Frank Li <Frank.Li@nxp.com>

The commit title should be:

ata: sata_dwc_460ex: use dmaengine_get_provider_device() in sata_dwc_dma_filter()

With that fixed, looks OK to me, so feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research