From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Heidelberg <david@ixit.cz>, Andi Shyti <andi.shyti@kernel.org>
Cc: Petr Hodina <petr.hodina@protonmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] Input: stmfts - do not abort event parsing on non-touch events
Date: Tue, 3 Nov 2026 14:58:41 -0800 [thread overview]
Message-ID: <20261103225923.3892612-2-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20261103225923.3892612-1-dmitry.torokhov@gmail.com>
When processing hardware interrupts, stmfts_read_events() reads a batch
of up to 32 events from the controller FIFO into the buffer. Only
STMFTS_EV_NO_EVENT (0x00) marks the end of valid events in this buffer.
Currently, both stmfts_parse_events() and stmfts5_parse_events() abort
the event parsing loop early upon encountering non-touch events such as
controller-ready, status, user-report, or debug events. This causes any
subsequent touch events that were already read from the FIFO in the same
batch to be discarded.
Update both event parsing loops so only STMFTS_EV_NO_EVENT terminates
processing, while non-touch events complete cmd_done when applicable and
continue processing the remaining entries in the FIFO buffer.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/stmfts.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index 727dc8041518..3613c7f2ab15 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -391,15 +391,17 @@ static void stmfts_parse_events(struct stmfts_data *sdata)
u8 *event = &sdata->data[i * STMFTS_EVENT_SIZE];
switch (event[0]) {
+ case STMFTS_EV_NO_EVENT:
+ return;
+
case STMFTS_EV_CONTROLLER_READY:
case STMFTS_EV_SLEEP_OUT_CONTROLLER_READY:
case STMFTS_EV_STATUS:
complete(&sdata->cmd_done);
fallthrough;
- case STMFTS_EV_NO_EVENT:
case STMFTS_EV_DEBUG:
- return;
+ continue;
}
switch (event[0] & STMFTS_MASK_EVENT_ID) {
@@ -442,19 +444,19 @@ static void stmfts5_parse_events(struct stmfts_data *sdata)
u8 *event = &sdata->data[i * STMFTS_EVENT_SIZE];
switch (event[0]) {
- case STMFTS5_EV_CONTROLLER_READY:
- complete(&sdata->cmd_done);
- fallthrough;
-
case STMFTS_EV_NO_EVENT:
goto sync;
+
+ case STMFTS5_EV_CONTROLLER_READY:
+ complete(&sdata->cmd_done);
+ continue;
}
switch (event[0] & STMFTS5_MASK_EVENT_ID) {
case STMFTS5_EV_STATUS_UPDATE:
case STMFTS5_EV_USER_REPORT:
case STMFTS5_EV_DEBUG:
- goto sync;
+ continue;
case STMFTS5_EV_MULTI_TOUCH_ENTER:
case STMFTS5_EV_MULTI_TOUCH_MOTION:
--
2.56.0.385.gac671c819a-goog
next prev parent reply other threads:[~2026-11-03 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 22:58 [PATCH 0/3] Input: stmfts - event parsing and coordinate reporting fixes Dmitry Torokhov
2026-11-03 22:58 ` Dmitry Torokhov [this message]
2026-11-03 22:58 ` [PATCH 2/3] Input: stmfts - validate slot ID in touch events Dmitry Torokhov
2026-11-03 22:58 ` [PATCH 3/3] Input: stmfts - use touchscreen_report_pos() for coordinates Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103225923.3892612-2-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=david@ixit.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr.hodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®