From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Heidelberg <david@ixit.cz>, Andi Shyti <andi.shyti@kernel.org>
Cc: Petr Hodina <petr.hodina@protonmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] Input: stmfts - use touchscreen_report_pos() for coordinates
Date: Tue, 3 Nov 2026 14:58:43 -0800 [thread overview]
Message-ID: <20261103225923.3892612-4-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20261103225923.3892612-1-dmitry.torokhov@gmail.com>
During driver initialization, stmfts_probe() invokes
touchscreen_parse_properties() to parse axis inversion and swapping
properties into sdata->prop.
However, stmfts_report_contact_event(), stmfts5_report_contact_event(),
and stmfts_report_hover_event() continue to report coordinates directly
using input_report_abs(), ignoring any configured axis inversion or
swapping settings in sdata->prop.
Update coordinate reporting across all three functions to use
touchscreen_report_pos() with &sdata->prop so that axis inversion and
swapping transformations are properly applied.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/stmfts.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index 25d127aa8642..f68da3e1309b 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -241,8 +241,7 @@ static void stmfts_report_contact_event(struct stmfts_data *sdata,
input_mt_slot(sdata->input, slot_id);
input_mt_report_slot_state(sdata->input, MT_TOOL_FINGER, true);
- input_report_abs(sdata->input, ABS_MT_POSITION_X, x);
- input_report_abs(sdata->input, ABS_MT_POSITION_Y, y);
+ touchscreen_report_pos(sdata->input, &sdata->prop, x, y, true);
input_report_abs(sdata->input, ABS_MT_TOUCH_MAJOR, maj);
input_report_abs(sdata->input, ABS_MT_TOUCH_MINOR, min);
input_report_abs(sdata->input, ABS_MT_PRESSURE, area);
@@ -344,8 +343,7 @@ static void stmfts5_report_contact_event(struct stmfts_data *sdata,
input_mt_slot(sdata->input, touch_id);
input_mt_report_slot_state(sdata->input, tool, true);
- input_report_abs(sdata->input, ABS_MT_POSITION_X, x);
- input_report_abs(sdata->input, ABS_MT_POSITION_Y, y);
+ touchscreen_report_pos(sdata->input, &sdata->prop, x, y, true);
input_report_abs(sdata->input, ABS_MT_TOUCH_MAJOR, maj);
input_report_abs(sdata->input, ABS_MT_TOUCH_MINOR, min);
input_report_abs(sdata->input, ABS_MT_PRESSURE, area);
@@ -375,8 +373,7 @@ static void stmfts_report_hover_event(struct stmfts_data *sdata,
u16 y = (event[3] << 4) | (event[4] & STMFTS_MASK_Y_LSB);
u8 z = event[5];
- input_report_abs(sdata->input, ABS_X, x);
- input_report_abs(sdata->input, ABS_Y, y);
+ touchscreen_report_pos(sdata->input, &sdata->prop, x, y, false);
input_report_abs(sdata->input, ABS_DISTANCE, z);
input_sync(sdata->input);
--
2.56.0.385.gac671c819a-goog
prev parent reply other threads:[~2026-11-03 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 22:58 [PATCH 0/3] Input: stmfts - event parsing and coordinate reporting fixes Dmitry Torokhov
2026-11-03 22:58 ` [PATCH 1/3] Input: stmfts - do not abort event parsing on non-touch events Dmitry Torokhov
2026-11-03 22:58 ` [PATCH 2/3] Input: stmfts - validate slot ID in touch events Dmitry Torokhov
2026-11-03 22:58 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103225923.3892612-4-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=david@ixit.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr.hodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®