[PATCH ath-next] wifi: ath10k: don't warn about a pdev param the firmware lacks

[PATCH ath-next] wifi: ath10k: don't warn about a pdev param the firmware lacks

[Christopher Griffin via B4 Relay]

From: Christopher Griffin <christophergriffin05@gmail.com>

On firmware other than WMI-TLV, every start of the radio logs

  ath10k_pci 0000:01:00.0: pdev param 0 not supported by firmware

and every association of a station interface logs it again, followed by

  ath10k_pci 0000:01:00.0: failed to enable peer stats info: -95

ath10k_start() sets idle_ps_config and ath10k_bss_assoc() sets
peer_stats_info_enable; only the WMI-TLV pdev param map has them, the
others hold WMI_PDEV_PARAM_UNSUPPORTED, and the set returns -EOPNOTSUPP
after the warning. ath10k_start() already takes -EOPNOTSUPP as no
error, so the warning tells nothing.

Report an unsupported pdev param at debug level, as an unsupported
vdev param already is, and let ath10k_bss_assoc() take -EOPNOTSUPP as
no error too. A caller that needs the param still warns with the
error.

Seen with QCA9882 radios on 10.1 firmware used as scanning and test
stations: 204 "pdev param 0" and 62 "peer stats info" warnings in ten
hours on one access point.

Tested-on: QCA988X hw2.0 PCI 10.1-ct-8x-__fW-023-23ea9f8e
Tested-on: IPQ4019 hw1.0 AHB 10.4b-ct-4019-fW-14-fcb240f0
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Christopher Griffin <christophergriffin05@gmail.com>
---
Tested with ath10k-ct's copy of these two functions, which carries the
same lines (OpenWrt's default ath10k driver for these chips), on a
QCA9882 scan radio and the IPQ4019 radios of an Arista W-118: before,
each firmware start and each station association logged the warnings;
with the change, none in two firmware starts of each radio and an
association of the QCA9882 as a station. This patch itself is
compile-tested on ath-next (wmi.o, mac.o, W=1).
---
 drivers/net/wireless/ath/ath10k/mac.c | 2 +-
 drivers/net/wireless/ath/ath10k/wmi.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 8e604697d6c20..20b91e8abb5be 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3158,7 +3158,7 @@ static void ath10k_bss_assoc(struct ieee80211_hw *hw,
 
 	ret = ath10k_wmi_pdev_set_param(ar,
 					ar->wmi.pdev_param->peer_stats_info_enable, 1);
-	if (ret)
+	if (ret && ret != -EOPNOTSUPP)
 		ath10k_warn(ar, "failed to enable peer stats info: %d\n", ret);
 
 	ret = ath10k_wmi_vdev_up(ar, arvif->vdev_id, arvif->aid, arvif->bssid);
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index e57588c19c800..a2efd2188d111 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -6544,8 +6544,8 @@ ath10k_wmi_op_gen_pdev_set_param(struct ath10k *ar, u32 id, u32 value)
 	struct sk_buff *skb;
 
 	if (id == WMI_PDEV_PARAM_UNSUPPORTED) {
-		ath10k_warn(ar, "pdev param %d not supported by firmware\n",
-			    id);
+		ath10k_dbg(ar, ATH10K_DBG_WMI,
+			   "pdev param %d not supported by firmware\n", id);
 		return ERR_PTR(-EOPNOTSUPP);
 	}
 

---
base-commit: a3ddbb45768717b5c9f923489387cf55c838d1ad
change-id: 20261104-b4-ath10k-unsupported-pdev-param-4a1b9e3eb1fe

Best regards,
--  
Christopher Griffin <christophergriffin05@gmail.com>