Re: [PATCH v4 2/2] iio: adc: Add a driver for the Ingenic X1600 ADC

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 3 Nov 2026 12:47:14 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Nov 02, 2026 at 09:11:55PM +0100, Olivier Louvignes wrote:
> > The X1600's SAR ADC has four auxiliary channels, each with its own start
> > bit, interrupt flag and 12-bit result, and none of the touchscreen or
> > battery engines of the JZ47xx ADCs that ingenic-adc drives. Add a small
> > driver that exposes the four channels as voltages against the 3.3 V
> > reference.
> > 
> > The registers are in chapter 19 of the X1600 programming manual. The
> > ADC clock divider is even, as the manual has it (an odd value divides
> > by one less); the vendor kernel writes the divider minus one, which
> > gives a slightly faster clock than it asks for.
> > 
> > Tested on a HiBy R1, whose play/pause and volume keys sit on channel 0
> > behind adc-keys: all three read and report correctly.  
> 
> A few nit-picks below, otherwise feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

FWIW I took another quick look and don't have anything to add.
So given this is clearly approaching being applied, feel free
to send a new version once you've addresses the questions from
Conor.  No need to wait the normal period under these circumstances.

Jonathan