From: Conor Dooley <conor@kernel.org>
To: Olivier Louvignes <olivier@mgcrea.io>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: Add the Ingenic X1600 ADC
Date: Mon, 2 Nov 2026 20:48:05 +0000 [thread overview]
Message-ID: <20261102-salute-cylinder-22c9a8896ca9@spud> (raw)
In-Reply-To: <20261102201155.10948-2-olivier@mgcrea.io>
[-- Attachment #1: Type: text/plain, Size: 2889 bytes --]
On Mon, Nov 02, 2026 at 09:11:54PM +0100, Olivier Louvignes wrote:
> The X1600's SAR ADC has four auxiliary channels and none of the
> touchscreen or battery engines of the JZ47xx ADCs in ingenic,adc.yaml,
> so it gets a binding of its own.
>
> Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
> ---
> .../bindings/iio/adc/ingenic,x1600-adc.yaml | 53 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml b/Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml
> new file mode 100644
> index 000000000000..f6356ea97980
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ingenic,x1600-adc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ingenic X1600 ADC
> +
> +maintainers:
> + - Olivier Louvignes <olivier@mgcrea.io>
> +
> +description:
> + The SAR ADC of the Ingenic X1600 SoC, with four auxiliary input channels
> + measured against a 3.3 V reference.
The wording here makes me wonder if a 3v3 supply is missing here? Or is
this some internal supply on the soc?
Otherwise, this looks fine really.
> +
> +properties:
> + compatible:
> + const: ingenic,x1600-adc
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + '#io-channel-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - interrupts
> + - '#io-channel-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + adc@10070000 {
> + compatible = "ingenic,x1600-adc";
> + reg = <0x10070000 0x30>;
That said, the 0x30 looks suspiciously small - but the region is aligned
neatly so I suppose it's probably not problematic..
Cheers,
Conor.
> +
> + clocks = <&cgu 28>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <11>;
> +
> + #io-channel-cells = <1>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ecc22d1149d1..fd4bb5c6bf16 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12925,6 +12925,11 @@ F: include/linux/mfd/ingenic-tcu.h
> F: sound/soc/codecs/jz47*
> F: sound/soc/jz4740/
>
> +INGENIC X1600 ADC DRIVER
> +M: Olivier Louvignes <olivier@mgcrea.io>
> +S: Maintained
> +F: Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml
> +
> INJOINIC IP5xxx POWER BANK IC DRIVER
> M: Samuel Holland <samuel@sholland.org>
> S: Maintained
> --
> 2.54.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-02 20:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 20:11 [PATCH v4 0/2] " Olivier Louvignes
2026-11-02 20:11 ` [PATCH v4 1/2] dt-bindings: " Olivier Louvignes
2026-11-02 20:48 ` Conor Dooley [this message]
2026-11-05 9:57 ` H. Nikolaus Schaller
2026-11-05 13:18 ` H. Nikolaus Schaller
2026-11-05 19:08 ` Conor Dooley
2026-11-02 20:11 ` [PATCH v4 2/2] iio: adc: Add a driver for " Olivier Louvignes
2026-11-03 10:47 ` Andy Shevchenko
2026-11-04 2:04 ` Jonathan Cameron
2026-11-05 9:50 ` [PATCH v4 0/2] iio: adc: Add " H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102-salute-cylinder-22c9a8896ca9@spud \
--to=conor@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier@mgcrea.io \
--cc=paul@crapouillou.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®