* [PATCH] wifi: ath12k: skip hardware rfkill setup on Surface Laptop 8th Edition
@ 2026-11-03 9:40 Gopikrishna Garmidi
2026-11-03 19:48 ` kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: Gopikrishna Garmidi @ 2026-11-03 9:40 UTC (permalink / raw)
To: jjohnson
Cc: linux-wireless, ath12k, linux-kernel, sibi.sankar, Gopikrishna Garmidi
The Surface Laptop 8th Edition (13.8") has the same broken WCN7850
rfkill input as the Surface Laptop 7, so Wi-Fi stays hard blocked.
Add it to the broken rfkill table.
Tested on a Surface Laptop 8th Edition (13.8").
Assisted-by: LLM
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
index 25987bc58556..35a440742456 100644
--- a/drivers/net/wireless/ath/ath12k/core.c
+++ b/drivers/net/wireless/ath/ath12k/core.c
@@ -87,6 +87,7 @@ static const struct ath12k_core_broken_rfkill_table {
{ ATH12K_HW_WCN7850_HW20, "microsoft,denali" },
{ ATH12K_HW_WCN7850_HW20, "microsoft,romulus13" },
{ ATH12K_HW_WCN7850_HW20, "microsoft,romulus15" },
+ { ATH12K_HW_WCN7850_HW20, "microsoft,surface-laptop-8-13p8" }
{ /* Sentinel */ }
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: ath12k: skip hardware rfkill setup on Surface Laptop 8th Edition
2026-11-03 9:40 [PATCH] wifi: ath12k: skip hardware rfkill setup on Surface Laptop 8th Edition Gopikrishna Garmidi
@ 2026-11-03 19:48 ` kernel test robot
2026-11-04 5:24 ` Gopikrishna Garmidi
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-11-03 19:48 UTC (permalink / raw)
To: Gopikrishna Garmidi, jjohnson
Cc: oe-kbuild-all, linux-wireless, ath12k, linux-kernel, sibi.sankar,
Gopikrishna Garmidi
Hi Gopikrishna,
kernel test robot noticed the following build errors:
[auto build test ERROR on ath/ath-next]
[also build test ERROR on wireless-next/main linus/master next-20261030]
[cannot apply to wireless/main v7.3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gopikrishna-Garmidi/wifi-ath12k-skip-hardware-rfkill-setup-on-Surface-Laptop-8th-Edition/20261103-014024
base: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git ath-next
patch link: https://lore.kernel.org/r/20261103094024.1764151-1-gopikrishna.garmidi%40oss.qualcomm.com
patch subject: [PATCH] wifi: ath12k: skip hardware rfkill setup on Surface Laptop 8th Edition
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20261104/202611040318.qlss0Yol-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261104/202611040318.qlss0Yol-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611040318.qlss0Yol-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath12k/core.c:91:9: error: expected '}' before '{' token
91 | { /* Sentinel */ }
| ^
drivers/net/wireless/ath/ath12k/core.c:86:39: note: to match this '{'
86 | } ath12k_core_broken_rfkill_table[] = {
| ^
vim +91 drivers/net/wireless/ath/ath12k/core.c
defae535dd63b1 Aaradhana Sahu 2025-07-08 76
5949d1910f13c2 François Roux 2026-10-06 77 /*
5949d1910f13c2 François Roux 2026-10-06 78 * On these machines the OS cannot control the WCN7850 hardware rfkill
5949d1910f13c2 François Roux 2026-10-06 79 * input, which reads as "radio off", so hardware rfkill must stay
5949d1910f13c2 François Roux 2026-10-06 80 * disabled. Ideally this would come from the connector node of the board
5949d1910f13c2 François Roux 2026-10-06 81 * DT, but that binding does not exist yet.
5949d1910f13c2 François Roux 2026-10-06 82 */
5949d1910f13c2 François Roux 2026-10-06 83 static const struct ath12k_core_broken_rfkill_table {
5949d1910f13c2 François Roux 2026-10-06 84 enum ath12k_hw_rev hw_rev;
5949d1910f13c2 François Roux 2026-10-06 85 const char *compatible;
5949d1910f13c2 François Roux 2026-10-06 86 } ath12k_core_broken_rfkill_table[] = {
5949d1910f13c2 François Roux 2026-10-06 87 { ATH12K_HW_WCN7850_HW20, "microsoft,denali" },
5949d1910f13c2 François Roux 2026-10-06 88 { ATH12K_HW_WCN7850_HW20, "microsoft,romulus13" },
5949d1910f13c2 François Roux 2026-10-06 89 { ATH12K_HW_WCN7850_HW20, "microsoft,romulus15" },
2d169d089ae8e1 Gopikrishna Garmidi 2026-11-03 90 { ATH12K_HW_WCN7850_HW20, "microsoft,surface-laptop-8-13p8" }
5949d1910f13c2 François Roux 2026-10-06 @91 { /* Sentinel */ }
5949d1910f13c2 François Roux 2026-10-06 92 };
5949d1910f13c2 François Roux 2026-10-06 93
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: ath12k: skip hardware rfkill setup on Surface Laptop 8th Edition
2026-11-03 19:48 ` kernel test robot
@ 2026-11-04 5:24 ` Gopikrishna Garmidi
0 siblings, 0 replies; 3+ messages in thread
From: Gopikrishna Garmidi @ 2026-11-04 5:24 UTC (permalink / raw)
To: kernel test robot, jjohnson
Cc: oe-kbuild-all, linux-wireless, ath12k, linux-kernel, sibi.sankar
On 11/4/2026 1:18 AM, kernel test robot wrote:
> Hi Gopikrishna,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on ath/ath-next]
> [also build test ERROR on wireless-next/main linus/master next-20261030]
> [cannot apply to wireless/main v7.3]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Gopikrishna-Garmidi/wifi-ath12k-skip-hardware-rfkill-setup-on-Surface-Laptop-8th-Edition/20261103-014024
> base: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git ath-next
> patch link: https://lore.kernel.org/r/20261103094024.1764151-1-gopikrishna.garmidi%40oss.qualcomm.com
> patch subject: [PATCH] wifi: ath12k: skip hardware rfkill setup on Surface Laptop 8th Edition
> config: arm64-defconfig (https://download.01.org/0day-ci/archive/20261104/202611040318.qlss0Yol-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 16.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261104/202611040318.qlss0Yol-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202611040318.qlss0Yol-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> drivers/net/wireless/ath/ath12k/core.c:91:9: error: expected '}' before '{' token
> 91 | { /* Sentinel */ }
> | ^
> drivers/net/wireless/ath/ath12k/core.c:86:39: note: to match this '{'
> 86 | } ath12k_core_broken_rfkill_table[] = {
> | ^
>
>
> vim +91 drivers/net/wireless/ath/ath12k/core.c
>
> defae535dd63b1 Aaradhana Sahu 2025-07-08 76
> 5949d1910f13c2 François Roux 2026-10-06 77 /*
> 5949d1910f13c2 François Roux 2026-10-06 78 * On these machines the OS cannot control the WCN7850 hardware rfkill
> 5949d1910f13c2 François Roux 2026-10-06 79 * input, which reads as "radio off", so hardware rfkill must stay
> 5949d1910f13c2 François Roux 2026-10-06 80 * disabled. Ideally this would come from the connector node of the board
> 5949d1910f13c2 François Roux 2026-10-06 81 * DT, but that binding does not exist yet.
> 5949d1910f13c2 François Roux 2026-10-06 82 */
> 5949d1910f13c2 François Roux 2026-10-06 83 static const struct ath12k_core_broken_rfkill_table {
> 5949d1910f13c2 François Roux 2026-10-06 84 enum ath12k_hw_rev hw_rev;
> 5949d1910f13c2 François Roux 2026-10-06 85 const char *compatible;
> 5949d1910f13c2 François Roux 2026-10-06 86 } ath12k_core_broken_rfkill_table[] = {
> 5949d1910f13c2 François Roux 2026-10-06 87 { ATH12K_HW_WCN7850_HW20, "microsoft,denali" },
> 5949d1910f13c2 François Roux 2026-10-06 88 { ATH12K_HW_WCN7850_HW20, "microsoft,romulus13" },
> 5949d1910f13c2 François Roux 2026-10-06 89 { ATH12K_HW_WCN7850_HW20, "microsoft,romulus15" },
> 2d169d089ae8e1 Gopikrishna Garmidi 2026-11-03 90 { ATH12K_HW_WCN7850_HW20, "microsoft,surface-laptop-8-13p8" }
> 5949d1910f13c2 François Roux 2026-10-06 @91 { /* Sentinel */ }
> 5949d1910f13c2 François Roux 2026-10-06 92 };
> 5949d1910f13c2 François Roux 2026-10-06 93
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
Thanks, fixed in v2:
https://lore.kernel.org/all/20261104051838.2912931-1-gopikrishna.garmidi@oss.qualcomm.com/
Thanks,
Gopikrishna
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-04 5:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-03 9:40 [PATCH] wifi: ath12k: skip hardware rfkill setup on Surface Laptop 8th Edition Gopikrishna Garmidi
2026-11-03 19:48 ` kernel test robot
2026-11-04 5:24 ` Gopikrishna Garmidi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®