* [PATCH v4 1/3] dt-bindings: iio: light: gp2ap002: add leda power supply
2026-11-04 13:02 [PATCH v4 0/3] MSM8916: improve gp2ap002 proximity sensor Christoph Rudorff
@ 2026-11-04 13:02 ` Christoph Rudorff
2026-11-04 19:45 ` Rob Herring
2026-11-04 13:02 ` [PATCH v4 2/3] iio: light: gp2ap002: add led " Christoph Rudorff
2026-11-04 13:02 ` [PATCH v4 3/3] arm64: dts: qcom: msm8916-samsung-j5: Add proximity sensor Christoph Rudorff
2 siblings, 1 reply; 6+ messages in thread
From: Christoph Rudorff @ 2026-11-04 13:02 UTC (permalink / raw)
To: Linus Walleij, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-iio, linux-kernel, devicetree, linux-arm-msm, Christoph Rudorff
According to datasheet page 8 "Recommended external circuit",
it has tree pins that need power: vio, vdd and leda ("vled" !)
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Christoph Rudorff <chris@rudorff.com>
---
Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
index 99bddf31cbed..643021f1d820 100644
--- a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
+++ b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
@@ -33,6 +33,9 @@ properties:
vio-supply:
description: VIO power supply a phandle to a regulator
+ leda-supply:
+ description: LED anode power supply a phandle to a regulator
+
io-channels:
maxItems: 1
description: ALSOUT ADC channel to read the ambient light
--
2.39.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v4 2/3] iio: light: gp2ap002: add led power supply
2026-11-04 13:02 [PATCH v4 0/3] MSM8916: improve gp2ap002 proximity sensor Christoph Rudorff
2026-11-04 13:02 ` [PATCH v4 1/3] dt-bindings: iio: light: gp2ap002: add leda power supply Christoph Rudorff
@ 2026-11-04 13:02 ` Christoph Rudorff
2026-11-04 17:31 ` Andy Shevchenko
2026-11-04 13:02 ` [PATCH v4 3/3] arm64: dts: qcom: msm8916-samsung-j5: Add proximity sensor Christoph Rudorff
2 siblings, 1 reply; 6+ messages in thread
From: Christoph Rudorff @ 2026-11-04 13:02 UTC (permalink / raw)
To: Linus Walleij, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-iio, linux-kernel, devicetree, linux-arm-msm, Christoph Rudorff
Problem: no irq received. Not working.
According to datasheet page 8 "Recommended external circuit",
it got tree pins to supply: vio, vdd and vled->leda.
We were missing to power the led (pin leda)
* add leda regulator
* use regulator_bulk_*()
* pretty up set voltages
Tested on samsung-j5 (msm8916)
Signed-off-by: Christoph Rudorff <chris@rudorff.com>
v2: Use regulator bulk api.
v3: pretty up, rename vled to leda
v4: add namespace "GP2AP002", use separate value for setting vdd,
moved static supply-data back to global, more readable imho
---
drivers/iio/light/gp2ap002.c | 92 +++++++++++++++++++++-----------------------
1 file changed, 43 insertions(+), 49 deletions(-)
diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c
index de29081fd3b2..db4edcc9b849 100644
--- a/drivers/iio/light/gp2ap002.c
+++ b/drivers/iio/light/gp2ap002.c
@@ -123,12 +123,24 @@
#define GP2AP002_CON_OCON_HIGH (0x3 << GP2AP002_CON_OCON_SHIFT)
#define GP2AP002_CON_OCON_MASK (0x3 << GP2AP002_CON_OCON_SHIFT)
+enum {
+ GP2AP002_SUPPLY_VIO,
+ GP2AP002_SUPPLY_VDD,
+ GP2AP002_SUPPLY_LEDA,
+ GP2AP002_NUM_SUPPLIES
+};
+
+static const char *const gp2ap002_supply_names[GP2AP002_NUM_SUPPLIES] = {
+ [GP2AP002_SUPPLY_VIO] = "vio",
+ [GP2AP002_SUPPLY_VDD] = "vdd",
+ [GP2AP002_SUPPLY_LEDA] = "leda",
+};
+
/**
* struct gp2ap002 - GP2AP002 state
* @map: regmap pointer for the i2c regmap
* @dev: pointer to parent device
- * @vdd: regulator controlling VDD
- * @vio: regulator controlling VIO
+ * @supplies: bulk regulator data
* @alsout: IIO ADC channel to convert the ALSOUT signal
* @hys_far: hysteresis control from device tree
* @hys_close: hysteresis control from device tree
@@ -140,8 +152,7 @@
struct gp2ap002 {
struct regmap *map;
struct device *dev;
- struct regulator *vdd;
- struct regulator *vio;
+ struct regulator_bulk_data supplies[GP2AP002_NUM_SUPPLIES];
struct iio_channel *alsout;
u8 hys_far;
u8 hys_close;
@@ -445,7 +456,7 @@ static int gp2ap002_probe(struct i2c_client *client)
int num_chan;
const char *compat;
u8 val;
- int ret;
+ int ret, vdd_volt;
indio_dev = devm_iio_device_alloc(dev, sizeof(*gp2ap002));
if (!indio_dev)
@@ -521,45 +532,39 @@ static int gp2ap002_probe(struct i2c_client *client)
}
}
- gp2ap002->vdd = devm_regulator_get(dev, "vdd");
- if (IS_ERR(gp2ap002->vdd))
- return dev_err_probe(dev, PTR_ERR(gp2ap002->vdd),
- "failed to get VDD regulator\n");
+ regulator_bulk_set_supply_names(gp2ap002->supplies,
+ gp2ap002_supply_names,
+ GP2AP002_NUM_SUPPLIES);
- gp2ap002->vio = devm_regulator_get(dev, "vio");
- if (IS_ERR(gp2ap002->vio))
- return dev_err_probe(dev, PTR_ERR(gp2ap002->vio),
- "failed to get VIO regulator\n");
+ ret = devm_regulator_bulk_get(dev, GP2AP002_NUM_SUPPLIES, gp2ap002->supplies);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to get regulators\n");
- /* Operating voltage 2.4V .. 3.6V according to datasheet */
- ret = regulator_set_voltage(gp2ap002->vdd, 2400000, 3600000);
+ /* vdd operating voltage 2.4V .. 3.6V according to datasheet */
+ ret = regulator_set_voltage(gp2ap002->supplies[GP2AP002_SUPPLY_VDD].consumer,
+ 2400000, 3600000);
if (ret) {
- dev_err(dev, "failed to sett VDD voltage\n");
+ dev_err(dev, "failed to set VDD voltage\n");
return ret;
}
-
/* VIO should be between 1.65V and VDD */
- ret = regulator_get_voltage(gp2ap002->vdd);
- if (ret < 0) {
+ vdd_volt = regulator_get_voltage(gp2ap002->supplies[GP2AP002_SUPPLY_VDD].consumer);
+ if (vdd_volt < 0) {
dev_err(dev, "failed to get VDD voltage\n");
- return ret;
+ return vdd_volt;
}
- ret = regulator_set_voltage(gp2ap002->vio, 1650000, ret);
+ ret = regulator_set_voltage(gp2ap002->supplies[GP2AP002_SUPPLY_VIO].consumer,
+ 1650000, vdd_volt);
if (ret) {
dev_err(dev, "failed to set VIO voltage\n");
return ret;
}
- ret = regulator_enable(gp2ap002->vdd);
+ ret = regulator_bulk_enable(GP2AP002_NUM_SUPPLIES, gp2ap002->supplies);
if (ret) {
- dev_err(dev, "failed to enable VDD regulator\n");
+ dev_err(dev, "failed to enable regulators\n");
return ret;
}
- ret = regulator_enable(gp2ap002->vio);
- if (ret) {
- dev_err(dev, "failed to enable VIO regulator\n");
- goto out_disable_vdd;
- }
msleep(20);
@@ -570,7 +575,7 @@ static int gp2ap002_probe(struct i2c_client *client)
ret = gp2ap002_init(gp2ap002);
if (ret) {
dev_err(dev, "initialization failed\n");
- goto out_disable_vio;
+ goto out_disable_power;
}
pm_runtime_get_noresume(dev);
pm_runtime_set_active(dev);
@@ -616,10 +621,8 @@ static int gp2ap002_probe(struct i2c_client *client)
pm_runtime_put_noidle(dev);
out_disable_pm:
pm_runtime_disable(dev);
-out_disable_vio:
- regulator_disable(gp2ap002->vio);
-out_disable_vdd:
- regulator_disable(gp2ap002->vdd);
+out_disable_power:
+ regulator_bulk_disable(GP2AP002_NUM_SUPPLIES, gp2ap002->supplies);
return ret;
}
@@ -633,8 +636,7 @@ static void gp2ap002_remove(struct i2c_client *client)
pm_runtime_put_noidle(dev);
pm_runtime_disable(dev);
iio_device_unregister(indio_dev);
- regulator_disable(gp2ap002->vio);
- regulator_disable(gp2ap002->vdd);
+ regulator_bulk_disable(GP2AP002_NUM_SUPPLIES, gp2ap002->supplies);
}
static int gp2ap002_runtime_suspend(struct device *dev)
@@ -657,8 +659,7 @@ static int gp2ap002_runtime_suspend(struct device *dev)
* As these regulators may be shared, at least we are now in
* sleep even if the regulators aren't really turned off.
*/
- regulator_disable(gp2ap002->vio);
- regulator_disable(gp2ap002->vdd);
+ regulator_bulk_disable(GP2AP002_NUM_SUPPLIES, gp2ap002->supplies);
return 0;
}
@@ -669,23 +670,18 @@ static int gp2ap002_runtime_resume(struct device *dev)
struct gp2ap002 *gp2ap002 = iio_priv(indio_dev);
int ret;
- ret = regulator_enable(gp2ap002->vdd);
+ ret = regulator_bulk_enable(GP2AP002_NUM_SUPPLIES, gp2ap002->supplies);
if (ret) {
- dev_err(dev, "failed to enable VDD regulator in resume path\n");
+ dev_err(dev, "failed to enable regulators in resume path\n");
return ret;
}
- ret = regulator_enable(gp2ap002->vio);
- if (ret) {
- dev_err(dev, "failed to enable VIO regulator in resume path\n");
- goto out_disable_vdd;
- }
msleep(20);
ret = gp2ap002_init(gp2ap002);
if (ret) {
dev_err(dev, "re-initialization failed\n");
- goto out_disable_vio;
+ goto out_disable_power;
}
/* Re-activate the IRQ */
@@ -693,10 +689,8 @@ static int gp2ap002_runtime_resume(struct device *dev)
return 0;
-out_disable_vio:
- regulator_disable(gp2ap002->vio);
-out_disable_vdd:
- regulator_disable(gp2ap002->vdd);
+out_disable_power:
+ regulator_bulk_disable(GP2AP002_NUM_SUPPLIES, gp2ap002->supplies);
return ret;
}
--
2.39.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v4 3/3] arm64: dts: qcom: msm8916-samsung-j5: Add proximity sensor
2026-11-04 13:02 [PATCH v4 0/3] MSM8916: improve gp2ap002 proximity sensor Christoph Rudorff
2026-11-04 13:02 ` [PATCH v4 1/3] dt-bindings: iio: light: gp2ap002: add leda power supply Christoph Rudorff
2026-11-04 13:02 ` [PATCH v4 2/3] iio: light: gp2ap002: add led " Christoph Rudorff
@ 2026-11-04 13:02 ` Christoph Rudorff
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Rudorff @ 2026-11-04 13:02 UTC (permalink / raw)
To: Linus Walleij, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-iio, linux-kernel, devicetree, linux-arm-msm, Christoph Rudorff
J5 got a gp2ap002 sensor, add it and it's supplies to the device tree
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Christoph Rudorff <chris@rudorff.com>
v4: moved declarations from j5-common to j5
---
arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts | 52 +++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts
index ba8650971d6a..efac29485df8 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts
@@ -8,6 +8,17 @@ / {
model = "Samsung Galaxy J5 (2015)";
compatible = "samsung,j5", "qcom,msm8916";
chassis-type = "handset";
+
+ reg_leda_proximity: regulator-leda-proximity {
+ compatible = "regulator-fixed";
+ regulator-name = "proximity_leda";
+
+ gpio = <&tlmm 73 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ pinctrl-0 = <&proximity_ldo_en_default>;
+ pinctrl-names = "default";
+ };
};
&accelerometer {
@@ -19,6 +30,24 @@ &blsp_i2c5 {
status = "disabled";
};
+&i2c_sensors {
+ proximity-sensor@44 {
+ compatible = "sharp,gp2ap002s00f";
+ reg = <0x44>;
+ interrupt-parent = <&tlmm>;
+ interrupts = <113 IRQ_TYPE_EDGE_FALLING>;
+ vdd-supply = <&pm8916_l17>;
+ vio-supply = <&pm8916_l5>;
+ leda-supply = <®_leda_proximity>;
+
+ sharp,proximity-far-hysteresis = /bits/ 8 <0x2f>;
+ sharp,proximity-close-hysteresis = /bits/ 8 <0x0f>;
+
+ pinctrl-0 = <&proximity_int_default>;
+ pinctrl-names = "default";
+ };
+};
+
&pm8916_codec {
qcom,micbias1-ext-cap;
};
@@ -30,3 +59,26 @@ &touchscreen {
&usb_hs_phy {
qcom,init-seq = /bits/ 8 <0x1 0x19 0x2 0x0b>;
};
+
+&pm8916_rpm_regulators {
+ pm8916_l17: l17 {
+ regulator-min-microvolt = <2850000>;
+ regulator-max-microvolt = <3100000>;
+ };
+};
+
+&tlmm {
+ proximity_ldo_en_default: proximity-ldo-en-default-state {
+ pins = "gpio73";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ proximity_int_default: proximity-int-default-state {
+ pins = "gpio113";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+};
--
2.39.5
^ permalink raw reply [flat|nested] 6+ messages in thread