mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] KVM: selftests: add empty install and run_tests targets for unsupported ARCHs
@ 2026-11-04 19:36 Sasha Levin
  2026-11-04 23:02 ` Sean Christopherson
  0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2026-11-04 19:36 UTC (permalink / raw)
  To: Sean Christopherson, Paolo Bonzini
  Cc: Shuah Khan, kvm, linux-kselftest, linux-kernel

Commit 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean'
targets for unsupported ARCHs") gave the KVM selftests empty all and
clean targets on architectures without KVM selftests, such as 32-bit
arm and i386. The selftests Makefile also runs install and run_tests
in each suite, and those still fail there:

  make[1]: *** No rule to make target 'install'.  Stop.

Add empty install and run_tests targets as well.

Fixes: 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
Found with KernelCI-style TuxMake builds that record per-suite results
with KSFT_BUILD_REPORT. 32-bit arm builds now succeed without installing
anything.

 tools/testing/selftests/kvm/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
index 03d91f00092f4..3881df8d5b2b8 100644
--- a/tools/testing/selftests/kvm/Makefile
+++ b/tools/testing/selftests/kvm/Makefile
@@ -13,4 +13,6 @@ else
 # Empty targets for unsupported architectures
 all:
 clean:
+install:
+run_tests:
 endif
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: selftests: add empty install and run_tests targets for unsupported ARCHs
  2026-11-04 19:36 [PATCH] KVM: selftests: add empty install and run_tests targets for unsupported ARCHs Sasha Levin
@ 2026-11-04 23:02 ` Sean Christopherson
  2026-11-04 23:38   ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Christopherson @ 2026-11-04 23:02 UTC (permalink / raw)
  To: Sasha Levin; +Cc: Paolo Bonzini, Shuah Khan, kvm, linux-kselftest, linux-kernel

On Wed, Nov 04, 2026, Sasha Levin wrote:
> Commit 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean'
> targets for unsupported ARCHs") gave the KVM selftests empty all and
> clean targets on architectures without KVM selftests, such as 32-bit
> arm and i386. The selftests Makefile also runs install and run_tests
> in each suite, and those still fail there:
> 
>   make[1]: *** No rule to make target 'install'.  Stop.
> 
> Add empty install and run_tests targets as well.
> 
> Fixes: 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs")
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---

Deuling AIs?  The other patch seems like a superset.

https://lore.kernel.org/all/20261014200152.1365147-1-sashal@kernel.org

> Found with KernelCI-style TuxMake builds that record per-suite results
> with KSFT_BUILD_REPORT. 32-bit arm builds now succeed without installing
> anything.
> 
>  tools/testing/selftests/kvm/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> index 03d91f00092f4..3881df8d5b2b8 100644
> --- a/tools/testing/selftests/kvm/Makefile
> +++ b/tools/testing/selftests/kvm/Makefile
> @@ -13,4 +13,6 @@ else
>  # Empty targets for unsupported architectures
>  all:
>  clean:
> +install:
> +run_tests:
>  endif
> -- 
> 2.53.0
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: selftests: add empty install and run_tests targets for unsupported ARCHs
  2026-11-04 23:02 ` Sean Christopherson
@ 2026-11-04 23:38   ` Sasha Levin
  0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2026-11-04 23:38 UTC (permalink / raw)
  To: Sean Christopherson
  Cc: Paolo Bonzini, Shuah Khan, kvm, linux-kselftest, linux-kernel

On Wed, Nov 04, 2026 at 03:02:45PM -0800, Sean Christopherson wrote:
> Deuling AIs?  The other patch seems like a superset.
>
> https://lore.kernel.org/all/20261014200152.1365147-1-sashal@kernel.org

Sorry, my mistake. Please take the October one and drop this.

This type of issue seems to happen everywhere in tools/, and I feel like
I'm in a giant game of whack-a-mole.

--
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-04 23:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-04 19:36 [PATCH] KVM: selftests: add empty install and run_tests targets for unsupported ARCHs Sasha Levin
2026-11-04 23:02 ` Sean Christopherson
2026-11-04 23:38   ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®