mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@kernel.org>,
	 Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	 Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	 spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] riscv: dts: spacemit: k3-com260-ifx: Drop wrong SD card vmmc-supply
Date: Thu, 05 Nov 2026 08:23:46 +0000	[thread overview]
Message-ID: <20261105-k3-com260-module-sd-nor-mac-v1-1-138b39d74602@linux.spacemit.com> (raw)
In-Reply-To: <20261105-k3-com260-module-sd-nor-mac-v1-0-138b39d74602@linux.spacemit.com>

The SD card VDD on the K3 CoM260 module comes from a fixed, always-on
3.3 V rail that software cannot control. ALDO4 of the P1 PMIC does not
supply the card, so referencing it as vmmc-supply describes the wrong
power wiring.

Drop the vmmc-supply property. It is optional for a card powered by a
fixed supply, and the SDHCI core then uses the voltages advertised by
the controller.

Fixes: 055044260e7a ("riscv: dts: spacemit: k3: Enable SD card support")
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
---
 arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
index fadcf28389be..6e295bc6f196 100644
--- a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
+++ b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
@@ -122,7 +122,6 @@ &sdhci0 {
 	no-sdio;
 	disable-wp;
 	cap-sd-highspeed;
-	vmmc-supply = <&aldo4>;
 	vqmmc-supply = <&aldo1>;
 	sd-uhs-sdr25;
 	sd-uhs-sdr50;

-- 
2.56.0


  reply	other threads:[~2026-11-05  8:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  8:23 [PATCH 0/5] riscv: dts: spacemit: k3-com260: Describe SD card, SPI NOR and MAC Troy Mitchell
2026-11-05  8:23 ` Troy Mitchell [this message]
2026-11-05  8:23 ` [PATCH 2/5] riscv: dts: spacemit: k3-com260: Move SD card to the module Troy Mitchell
2026-11-05  8:23 ` [PATCH 3/5] riscv: dts: spacemit: k3-com260: Add SPI NOR flash Troy Mitchell
2026-11-05  8:23 ` [PATCH 4/5] riscv: defconfig: Enable AT24 EEPROM and ONIE TLV layout Troy Mitchell
2026-11-05 10:42   ` E Shattow
2026-11-05 14:20     ` Troy Mitchell
2026-11-05  8:23 ` [PATCH 5/5] riscv: dts: spacemit: k3-com260: Set Ethernet MAC from EEPROM Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105-k3-com260-module-sd-nor-mac-v1-1-138b39d74602@linux.spacemit.com \
    --to=troy.mitchell@linux.spacemit.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®