mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Hongliang Yang (杨宏亮)" <hongliang.yang@cixtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Hongliang Yang (杨宏亮)" <hongliang.yang@cixtech.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: [PATCH v5 0/3] usb: cdns3: Add CIX Sky1 USBSSP controller support
Date: Thu, 5 Nov 2026 01:18:19 +0000	[thread overview]
Message-ID: <20261105011813.4058647-2-hongliang.yang@cixtech.com> (raw)
In-Reply-To: <25b75ddc-65d5-44e7-9a6e-861ed9c96f18@kernel.org>

Sorry for not responding to the earlier rounds of feedback - that was my
mistake.

The v5 USB cover was missing the changelog entirely; v6 has a complete
"Changes in v6" section covering each patch.

On the DT model: you were right that a shared register region is not a
simple-bus and that the representation was fake. v6 drops the container:
each controller node now sits at the address of its own glue registers
(usb@91c0314 and usb@91c0324), so the unit address matches real hardware,
and the Cadence core is a child at its real address (usb@91d0000 and
usb@91e0000) with an empty ranges property.

On the ABI: the usbN aliases and the id property are gone. The mode strap
register offset and bit position are passed as arguments of the
cix,usb-syscon phandle (0x424, bit 8 for USB4 and bit 10 for USB5), and
#syscon-cells = <2> is documented in the Sky1 system controller binding.
Nothing undocumented is parsed anymore.

Thanks,
Hongliang

      reply	other threads:[~2026-11-05  1:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  7:49 Hongliang Yang (杨宏亮)
2026-11-03  7:49 ` [PATCH v5 1/3] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang (杨宏亮)
2026-11-04  7:50   ` Krzysztof Kozlowski
2026-11-03  7:49 ` [PATCH v5 3/3] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang (杨宏亮)
2026-11-04  7:46   ` Krzysztof Kozlowski
2026-11-03  7:49 ` [PATCH v5 2/3] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang (杨宏亮)
2026-11-03  8:43   ` Philipp Zabel
2026-11-05  1:18     ` Hongliang Yang (杨宏亮)
2026-11-04  7:54   ` Krzysztof Kozlowski
2026-11-04  7:44 ` [PATCH v5 0/3] usb: cdns3: Add CIX Sky1 USBSSP controller support Krzysztof Kozlowski
2026-11-05  1:18   ` Hongliang Yang (杨宏亮) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105011813.4058647-2-hongliang.yang@cixtech.com \
    --to=hongliang.yang@cixtech.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®