[PATCH v2] platform/chrome: wilco_ec: Fix device reference leak on open failure

[PATCH v2] platform/chrome: wilco_ec: Fix device reference leak on open failure

[Yige Jiang]

telem_open() takes a reference to dev_data->dev before allocating
the session. If that allocation fails, it returns -ENOMEM without
dropping the reference. Since release is not called after a failed
open, the device data remains pinned after removal.

Take the device reference only after the session allocation succeeds,
so that a failed open does not leave an unbalanced reference. The
successful open path remains balanced by telem_release().

Fixes: 1210d1e6bad1 ("platform/chrome: wilco_ec: Add telemetry char device interface")
Signed-off-by: Yige Jiang <yigejiang86@gmail.com>
---
Changes in v2:
- Move get_device() after successful session allocation instead of
  adding put_device() to the allocation failure path, as suggested
  by Tzung-Bi Shih.
- Drop the obsolete Assisted-by trailer and retain the AI disclosure
  below.

v1 Message-ID: <rc-review-20261103-vc-85-d1e3d35e7c31@gmail.com>
Based on linux-next next-20261102 (2637bdec0535).
Compile-tested: baseline and v2 arm64 target objects, GCC 14.2.0, W=1.
CONFIG_COMPILE_TEST=y, CONFIG_OF_DYNAMIC=y, CONFIG_WILCO_EC_TELEMETRY=m.
No full kernel/module-link, hardware or runtime test was performed.
AI assistance: Codex (LLM) helped make the patch.

 drivers/platform/chrome/wilco_ec/telemetry.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c
index 45be318b05f6..b91cb62c4192 100644
--- a/drivers/platform/chrome/wilco_ec/telemetry.c
+++ b/drivers/platform/chrome/wilco_ec/telemetry.c
@@ -245,13 +245,13 @@
 	if (atomic_cmpxchg(&dev_data->available, 1, 0) == 0)
 		return -EBUSY;
 
-	get_device(&dev_data->dev);
-
 	sess_data = kzalloc_obj(*sess_data);
 	if (!sess_data) {
 		atomic_set(&dev_data->available, 1);
 		return -ENOMEM;
 	}
+
+	get_device(&dev_data->dev);
 	sess_data->dev_data = dev_data;
 	sess_data->has_msg = false;
 

base-commit: 2637bdec0535a2044cd830eba9a79363651d9043