From: Steven Rostedt <rostedt@goodmis.org>
To: Kirtikumar Anandrao Ramchandani <kirtiar15502@gmail.com>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com,
syzbot+eb74dca0d1eb3ec227a7@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] ring-buffer: Skip time delta validation for the counter clock
Date: Thu, 5 Nov 2026 09:07:06 -0500 [thread overview]
Message-ID: <20261105090706.19ed0e07@gandalf.local.home> (raw)
In-Reply-To: <CADZg-m0FeLntAS6XxE-kc74vwH-jAh+jXT68qnVwXuHZNUHzfA@mail.gmail.com>
On Wed, 4 Nov 2026 14:42:00 -0800
Kirtikumar Anandrao Ramchandani <kirtiar15502@gmail.com> wrote:
> The counter trace clock increments on every read. Time delta validation
> assumes that the clock values read while reserving and checking an event
> can be reconciled with the deltas stored in the page. With the counter
> clock, this assumption can fail for an intact ring buffer and report a
> spurious TIME DOES NOT MATCH warning.
>
> Skip time delta validation while the buffer uses trace_clock_counter().
> Clock selection already resets the buffer, so events recorded under a
> previous clock are not retained for this check. Recording and reading
> counter-clock events are unchanged.
>
> Link: https://lists.openwall.net/linux-kernel/2026/09/20/1283
Nit, the above should be a lore link, but thanks for doing my todo ;-)
-- Steve
> Reported-by: syzbot+eb74dca0d1eb3ec227a7@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=eb74dca0d1eb3ec227a7
> Signed-off-by: Kirtikumar Anandrao Ramchandani <kirtiar15502@gmail.com>
> ---
next prev parent reply other threads:[~2026-11-05 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADZg-m04iG5kCZ5-yh=Vz_ysYjVDGSYn3je4_-8AzWWfiC-bXQ@mail.gmail.com>
2026-11-04 22:42 ` Kirtikumar Anandrao Ramchandani
2026-11-05 14:07 ` Steven Rostedt [this message]
2026-11-05 14:19 ` [PATCH v3] " Kirtikumar Anandrao Ramchandani
2026-11-20 15:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105090706.19ed0e07@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kirtiar15502@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=syzbot+eb74dca0d1eb3ec227a7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®