mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Kirtikumar Anandrao Ramchandani <kirtiar15502@gmail.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com,
	syzbot+eb74dca0d1eb3ec227a7@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] ring-buffer: Skip time delta validation for the counter clock
Date: Fri, 20 Nov 2026 10:02:00 -0500	[thread overview]
Message-ID: <20261120100200.4f8ac19b@gandalf.local.home> (raw)
In-Reply-To: <CADZg-m3Wxkze0t9u1+dvn3Rrart54_eyi5XDcOSE+9W94s983Q@mail.gmail.com>

On Thu, 5 Nov 2026 06:19:54 -0800
Kirtikumar Anandrao Ramchandani <kirtiar15502@gmail.com> wrote:

> The counter trace clock increments on every read. Time delta validation
> assumes that the clock values read while reserving and checking an event
> can be reconciled with the deltas stored in the page. With the counter
> clock, this assumption can fail for an intact ring buffer and report a
> spurious TIME DOES NOT MATCH warning.
> 
> Skip time delta validation while the buffer uses trace_clock_counter().
> Clock selection already resets the buffer, so events recorded under a
> previous clock are not retained for this check. Recording and reading
> counter-clock events are unchanged.
> 
> Link: https://lore.kernel.org/all/20260920161648.7d9fda60@fedora/
> Reported-by: syzbot+eb74dca0d1eb3ec227a7@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=eb74dca0d1eb3ec227a7
> Signed-off-by: Kirtikumar Anandrao Ramchandani <kirtiar15502@gmail.com>

I'm going to hold off on applying this because I'm not fully convinced that
this isn't hiding a real bug.

I remember looking into this in the past and thinking I found the reason
the counter breaks the check, but when looking at the code again, I'm not
so sure. There may be a real bug here that only the counter can trigger. Or
at least trigger more reliably.

Until I'm sure there's not a real bug being hidden by this patch, I'm going
to keep allowing this to trigger on the counter clock.

Thanks,

-- Steve

      reply	other threads:[~2026-11-20 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADZg-m04iG5kCZ5-yh=Vz_ysYjVDGSYn3je4_-8AzWWfiC-bXQ@mail.gmail.com>
2026-11-04 22:42 ` [PATCH v2] " Kirtikumar Anandrao Ramchandani
2026-11-05 14:07   ` Steven Rostedt
2026-11-05 14:19   ` [PATCH v3] " Kirtikumar Anandrao Ramchandani
2026-11-20 15:02     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120100200.4f8ac19b@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kirtiar15502@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=syzbot+eb74dca0d1eb3ec227a7@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®