* [PATCH] GPU: drm: nouveau: Prevent kernel oops on missing firmware binary
[not found] <20261105202757.28703-1-jonathan.kuehn.ref@aol.com>
@ 2026-11-05 20:27 ` Jonathan Kuehn
0 siblings, 0 replies; only message in thread
From: Jonathan Kuehn @ 2026-11-05 20:27 UTC (permalink / raw)
To: lyude
Cc: dakr, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
airlied, dri-devel, nouveau, linux-kernel, Jonathan Kuehn
Prevent null pointer dereference at the call of
nouveau_abi16_ioctl_getparams with parameter
NOUVEAU_GETPARAM_GRAPH_UNITS when firmware binaries are missing.
Fixes crash for certain user-space applications (steamwebhelper,
signal-desktop).
Signed-off-by: Jonathan Kuehn <jonathan.kuehn@aol.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/base.c
index cd4908b1b4df..9abeb9732406 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/base.c
@@ -72,7 +72,7 @@ nvkm_gr_tile(struct nvkm_engine *engine, int region, struct nvkm_fb_tile *tile)
u64
nvkm_gr_units(struct nvkm_gr *gr)
{
- if (gr->func->units)
+ if (gr && gr->func->units)
return gr->func->units(gr);
return 0;
}
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread