mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH char-misc-next] mei: mei_lb: add info prints in flow
@ 2026-11-05 14:28 Alexander Usyskin
  2026-11-05 15:49 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Usyskin @ 2026-11-05 14:28 UTC (permalink / raw)
  To: Arnd Bergmann, Greg Kroah-Hartman
  Cc: Menachem Adin, linux-kernel, Alexander Usyskin

Add info prints for late bind flow start and successful completion.
We already have error prints, new info prints will add ability
to trace successful flow and confirm that late bind firmware
loaded to the card.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/mei_lb.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/mei/mei_lb.c b/drivers/misc/mei/mei_lb.c
index 9fa69acf28d5..51794ff994fa 100644
--- a/drivers/misc/mei/mei_lb.c
+++ b/drivers/misc/mei/mei_lb.c
@@ -214,6 +214,8 @@ static int mei_lb_push_payload_v1(struct device *dev, struct mei_cl_device *clde
 	ssize_t bytes;
 	int ret;
 
+	dev_info(dev, "Sending %zu bytes of type %u\n", payload_size, type);
+
 	req_size = struct_size(req, payload, payload_size);
 	if (req_size > mei_cldev_mtu(cldev)) {
 		dev_err(dev, "Payload is too big: %zu\n", payload_size);
@@ -260,8 +262,12 @@ static int mei_lb_push_payload_v1(struct device *dev, struct mei_cl_device *clde
 		goto end;
 	}
 
-	dev_dbg(dev, "status = %u\n", le32_to_cpu(rsp.status));
 	ret = (int)le32_to_cpu(rsp.status);
+
+	if (ret)
+		dev_err(dev, "Error in status: %d\n", ret);
+	else
+		dev_info(dev, "Sent %zu bytes of type %u successfully\n", payload_size, type);
 end:
 	kfree(req);
 	return ret;
@@ -314,6 +320,8 @@ static int mei_lb_push_payload_v2(struct device *dev, struct mei_cl_device *clde
 	ssize_t bytes;
 	int ret;
 
+	dev_info(dev, "Sending %zu bytes of type %u\n", payload_size, type);
+
 	struct mei_lb2_req *req __free(kfree) = kzalloc(mei_cldev_mtu(cldev), GFP_KERNEL);
 	if (!req)
 		return -ENOMEM;
@@ -363,6 +371,8 @@ static int mei_lb_push_payload_v2(struct device *dev, struct mei_cl_device *clde
 		first_chunk = 0;
 	} while (!last_chunk);
 
+	dev_info(dev, "Sent %zu bytes of type %u successfully\n", payload_size, type);
+
 	return 0;
 }
 

---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261105-mei_lb_add_info-0f5cb275f93a

Best regards,
-- 
Alexander Usyskin <alexander.usyskin@intel.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH char-misc-next] mei: mei_lb: add info prints in flow
  2026-11-05 14:28 [PATCH char-misc-next] mei: mei_lb: add info prints in flow Alexander Usyskin
@ 2026-11-05 15:49 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-11-05 15:49 UTC (permalink / raw)
  To: Alexander Usyskin; +Cc: Arnd Bergmann, Menachem Adin, linux-kernel

On Thu, Nov 05, 2026 at 04:28:03PM +0200, Alexander Usyskin wrote:
> Add info prints for late bind flow start and successful completion.
> We already have error prints, new info prints will add ability
> to trace successful flow and confirm that late bind firmware
> loaded to the card.

No, sorry, when a driver is working properly, it is quiet.  Never spam
kernel logs like this, that's just not needed.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-05 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-05 14:28 [PATCH char-misc-next] mei: mei_lb: add info prints in flow Alexander Usyskin
2026-11-05 15:49 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®