mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hongliang Yang <hongliang.yang@cixtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Peter Chen <peter.chen@kernel.org>,
	Pawel Laszczak <pawell@cadence.com>,
	Roger Quadros <rogerq@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: Hongliang Yang <hongliang.yang@cixtech.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
	Gary Yang <gary.yang@cixtech.com>,
	Fugang Duan <fugang.duan@cixtech.com>
Subject: Re: [PATCH v6 1/3] dt-bindings: usb: Add CIX Sky1 USBSSP controller
Date: Fri,  6 Nov 2026 15:28:49 +0800	[thread overview]
Message-ID: <20261106072849.985274-1-hongliang.yang@cixtech.com> (raw)
In-Reply-To: <8ffdf2f9-dd67-419f-83af-8dd4206d54de@kernel.org>

On 06/11/2026 08:01, Krzysztof Kozlowski wrote:
> So instead of replying under each comment, you selected a few of them
> and expect me to map/figure out which ones you ignored?

No. Compressing eight separate comments into one mail was the wrong way
to answer a review, and it is what made you match numbered paragraphs to
quotes yourself. I will answer under the individual messages instead.

> OK, then find me where did you reply to this:
>
> "And do not combine USB patches with other subsystems."
>
> "I do not see how you addressed my feedback from v1. I asked, not to
> combine USB patches with other subsystems, within one patchset. These
> are separate patchsets."

The first one, in the v1 thread:

  https://lore.kernel.org/all/20260902032306.1182941-1-hongliang.yang@cixtech.com/

where I wrote "Done in v2: the combined bindings patch is split into
separate patches with dt-bindings: phy: and dt-bindings: usb: subject
prefixes, one schema per patch". That answer was only half true: v2
split the bindings into separate patches, but the PHY and the USB series
were still submitted together. The series were actually split in v4, and
have been separate since:

  [PATCH v4 0/3] Add CIX Sky1 USB3 PHY support
    <20260906032431.470744-1-hongliang.yang@cixtech.com>
  [PATCH v4 0/4] Add CIX Sky1 USBSSP controller support
    <20260906032440.470788-1-hongliang.yang@cixtech.com>

The second one, on the v3 cover (6ca4ba08): I did not reply to it. The
split went into v4 with no mail saying so. There is no reply I can point
you to for that message, and I am not going to claim there is.

What remains are the per-patch comments on the binding that my previous
mail answered in summary form. I will reply to those under your original
messages, one at a time, rather than restate them here.

Hongliang

  reply	other threads:[~2026-11-06  7:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  1:18 [PATCH v6 0/3] usb: cdns3: Add CIX Sky1 USBSSP controller support Hongliang Yang (杨宏亮)
2026-11-05  1:18 ` [PATCH v6 1/3] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang (杨宏亮)
2026-11-05  7:49   ` Krzysztof Kozlowski
2026-11-06  5:50     ` Hongliang Yang
2026-11-06  7:01       ` Krzysztof Kozlowski
2026-11-06  7:28         ` Hongliang Yang [this message]
2026-11-06  7:39           ` Krzysztof Kozlowski
2026-11-06  8:17             ` Hongliang Yang
2026-11-05  1:18 ` [PATCH v6 2/3] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang (杨宏亮)
2026-11-05  1:18 ` [PATCH v6 3/3] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang (杨宏亮)
2026-11-05  7:48   ` Krzysztof Kozlowski
2026-11-06  5:50     ` Hongliang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106072849.985274-1-hongliang.yang@cixtech.com \
    --to=hongliang.yang@cixtech.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fugang.duan@cixtech.com \
    --cc=gary.yang@cixtech.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pawell@cadence.com \
    --cc=peter.chen@kernel.org \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®