mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Heming Zhao <heming.zhao@suse.com>
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
	ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: [PATCH v2 29/31] ocfs2: check chain list dinodes in online filecheck
Date: Fri,  6 Nov 2026 19:14:56 +0800	[thread overview]
Message-ID: <20261106111458.1467464-30-joseph.qi@linux.alibaba.com> (raw)
In-Reply-To: <20261106111458.1467464-1-joseph.qi@linux.alibaba.com>

Wire the chain-list guard and its three sub-checks into the filecheck
validator: cl_count against ocfs2_chain_recs_per_inode(),
cl_next_free_rec against cl_count, and cl_bpc against the cluster to
block size ratio.

The bits-per-cluster predicate keeps the two bitmap_blkno conditions, so
the global bitmap inode itself remains exempt.

Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
---
 fs/ocfs2/inode.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 1679ed7d09db..6865f0000e6f 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -2165,6 +2165,37 @@ static int ocfs2_filecheck_validate_inode_block(struct super_block *sb,
 		}
 	}
 
+	if (ocfs2_dinode_has_chain_list(di)) {
+		struct ocfs2_chain_list *cl = &di->id2.i_chain;
+
+		if (ocfs2_dinode_has_bad_chain_count(sb, di)) {
+			mlog(ML_ERROR,
+			     "Filecheck: invalid dinode #%llu: chain list count %u\n",
+			     (unsigned long long)bh->b_blocknr,
+			     le16_to_cpu(cl->cl_count));
+			rc = -OCFS2_FILECHECK_ERR_INVALIDINO;
+			goto bail;
+		}
+
+		if (ocfs2_dinode_has_bad_chain_next_free(di)) {
+			mlog(ML_ERROR,
+			     "Filecheck: invalid dinode #%llu: chain list index %u\n",
+			     (unsigned long long)bh->b_blocknr,
+			     le16_to_cpu(cl->cl_next_free_rec));
+			rc = -OCFS2_FILECHECK_ERR_INVALIDINO;
+			goto bail;
+		}
+
+		if (ocfs2_dinode_has_bad_chain_bpc(sb, di)) {
+			mlog(ML_ERROR,
+			     "Filecheck: invalid dinode #%llu: bits per cluster %u\n",
+			     (unsigned long long)bh->b_blocknr,
+			     le16_to_cpu(cl->cl_bpc));
+			rc = -OCFS2_FILECHECK_ERR_INVALIDINO;
+			goto bail;
+		}
+	}
+
 bail:
 	return rc;
 }
-- 
2.39.3


  parent reply	other threads:[~2026-11-06 11:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 11:14 [PATCH v2 00/31] ocfs2: split dinode validation into shared predicates Joseph Qi
2026-11-06 11:14 ` [PATCH v2 01/31] ocfs2: exempt orphaned dinodes from the zero nlink check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 02/31] ocfs2: abstract the zero nlink or mode dinode check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 03/31] ocfs2: abstract the dinode i_blkno mismatch check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 04/31] ocfs2: abstract the dinode OCFS2_VALID_FL check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 05/31] ocfs2: abstract the dinode fs_generation mismatch check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 06/31] ocfs2: abstract the dinode suballoc slot checks Joseph Qi
2026-11-06 11:14 ` [PATCH v2 07/31] ocfs2: abstract the dinode suballoc bit check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 08/31] ocfs2: abstract the dinode orphaned slot check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 09/31] ocfs2: abstract the dinode DIO " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 10/31] ocfs2: abstract the inline data dinode guard and cluster check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 11/31] ocfs2: abstract the inline data id_count bound check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 12/31] ocfs2: abstract the inline data i_size " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 13/31] ocfs2: abstract the fast symlink dinode guard and size check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 14/31] ocfs2: abstract the fast symlink NUL-termination check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 15/31] ocfs2: abstract the chain list dinode guard and count check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 16/31] ocfs2: abstract the chain list next free record check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 17/31] ocfs2: abstract the chain list bits per cluster check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 18/31] ocfs2: abstract the dinode refcount location check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 19/31] ocfs2: abstract the zero extent list count check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 20/31] ocfs2: abstract the oversized " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 21/31] ocfs2: abstract the extent list next free record check Joseph Qi
2026-11-06 11:14 ` [PATCH v2 22/31] ocfs2: report unrepairable corruption from online filecheck fix Joseph Qi
2026-11-06 11:14 ` [PATCH v2 23/31] ocfs2: check dinode nlink and mode in online filecheck Joseph Qi
2026-11-06 11:14 ` [PATCH v2 24/31] ocfs2: check dinode suballoc slot " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 25/31] ocfs2: check dinode suballoc bit " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 26/31] ocfs2: check dinode orphaned slots " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 27/31] ocfs2: check inline data dinodes " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 28/31] ocfs2: check fast symlink " Joseph Qi
2026-11-06 11:14 ` Joseph Qi [this message]
2026-11-06 11:14 ` [PATCH v2 30/31] ocfs2: check dinode refcount location " Joseph Qi
2026-11-06 11:14 ` [PATCH v2 31/31] ocfs2: check extent list dinodes " Joseph Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106111458.1467464-30-joseph.qi@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=heming.zhao@suse.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®