[PATCH] [PATCH net-next] net: sfp: add quirk for OEM SFP+ONU-XGSPON

[PATCH] [PATCH net-next] net: sfp: add quirk for OEM SFP+ONU-XGSPON

[Romit Sagu]

This XGS-PON ONU stick (vendor OEM, part SFP+ONU-XGSPON)
needs the same handling as other Potron-based modules. Without it,
the module fails to connect and the kernal shows these errors:
sfp sfp1: module transmit fault indicated
sfp sfp1: module persistently indicates fault, disabling

This module requires TX_FAULT/LOS behaviour and boot delay tuning.
Add a quirk using the existing sfp_fixup_potron.

Signed-off-by: Romit Sagu <romit@romitsagu.com>
---
 drivers/net/phy/sfp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 85e57a16bb52..9435b25b54c9 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -623,6 +623,10 @@ static const struct sfp_quirk sfp_quirks[] = {
 
 	SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron),
 
+	// OEM SFP+ONU-XGSPON is a XGS-PON ONT stick with broken TX_FAULT
+	// and slow startup, just like potron.
+	SFP_QUIRK_F("OEM", "SFP+ONU-XGSPON", sfp_fixup_potron),
+
 	// HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY.
 	SFP_QUIRK_F("OEM", "HC-10GE-113C", sfp_fixup_rollball),
 
-- 
2.43.0

Re: [PATCH] [PATCH net-next] net: sfp: add quirk for OEM SFP+ONU-XGSPON

[Andrew Lunn]

On Tue, Nov 03, 2026 at 01:18:42AM +0000, Romit Sagu wrote:
> 
> This XGS-PON ONU stick (vendor OEM, part SFP+ONU-XGSPON)
> needs the same handling as other Potron-based modules. Without it,
> the module fails to connect and the kernal shows these errors:
> sfp sfp1: module transmit fault indicated
> sfp sfp1: module persistently indicates fault, disabling
> 
> This module requires TX_FAULT/LOS behaviour and boot delay tuning.
> Add a quirk using the existing sfp_fixup_potron.
> 
> Signed-off-by: Romit Sagu <romit@romitsagu.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] [PATCH net-next] net: sfp: add quirk for OEM SFP+ONU-XGSPON

[Jakub Kicinski]

On Tue,  3 Nov 2026 01:18:42 +0000 Romit Sagu wrote:
>  	SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron),
>  
> +	// OEM SFP+ONU-XGSPON is a XGS-PON ONT stick with broken TX_FAULT
> +	// and slow startup, just like potron.
> +	SFP_QUIRK_F("OEM", "SFP+ONU-XGSPON", sfp_fixup_potron),
> +
>  	// HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY.
>  	SFP_QUIRK_F("OEM", "HC-10GE-113C", sfp_fixup_rollball),

The quirks seem to have been sorted alphabetically once upon a time.
And the OEM section is starting to look very randomly order.
Please put this in a better place?
-- 
pw-bot: cr

Re: [PATCH] [PATCH net-next] net: sfp: add quirk for OEM SFP+ONU-XGSPON

[Jakub Kicinski]

On Tue,  3 Nov 2026 01:18:42 +0000 Romit Sagu wrote:
> This XGS-PON ONU stick (vendor OEM, part SFP+ONU-XGSPON)
> needs the same handling as other Potron-based modules. Without it,
> the module fails to connect and the kernal shows these errors:
> sfp sfp1: module transmit fault indicated
> sfp sfp1: module persistently indicates fault, disabling
> 
> This module requires TX_FAULT/LOS behaviour and boot delay tuning.
> Add a quirk using the existing sfp_fixup_potron.
> 
> Signed-off-by: Romit Sagu <romit@romitsagu.com>
> ---
>  drivers/net/phy/sfp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index 85e57a16bb52..9435b25b54c9 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -623,6 +623,10 @@ static const struct sfp_quirk sfp_quirks[] = {
>  
>  	SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron),
>  
> +	// OEM SFP+ONU-XGSPON is a XGS-PON ONT stick with broken TX_FAULT
> +	// and slow startup, just like potron.
> +	SFP_QUIRK_F("OEM", "SFP+ONU-XGSPON", sfp_fixup_potron),
> +
>  	// HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY.
>  	SFP_QUIRK_F("OEM", "HC-10GE-113C", sfp_fixup_rollball),
>  

PS. AI also suggests mentioning LOS in the comment, since you have to
respin

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261103011849.181392-1-romit@romitsagu.com