* [PATCH] firmware: cs_dsp: Replace the obscure "invalid magic" messages
@ 2026-11-06 15:00 Richard Fitzgerald
0 siblings, 0 replies; only message in thread
From: Richard Fitzgerald @ 2026-11-06 15:00 UTC (permalink / raw)
To: broonie; +Cc: linux-sound, linux-kernel, patches
Replace the obscure "invalid magic" messages with messages that say what
the actual problem is: the file is not the expected type.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
drivers/firmware/cirrus/cs_dsp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c
index 4dcce87685d3..a7e2a4fb0894 100644
--- a/drivers/firmware/cirrus/cs_dsp.c
+++ b/drivers/firmware/cirrus/cs_dsp.c
@@ -1551,7 +1551,7 @@ static int cs_dsp_load(struct cs_dsp *dsp, const struct firmware *firmware,
header = (void *)&firmware->data[0];
if (memcmp(&header->magic[0], "WMFW", 4) != 0) {
- cs_dsp_err(dsp, "%s: invalid magic\n", file);
+ cs_dsp_err(dsp, "%s: not a WMFW file\n", file);
goto out_fw;
}
@@ -2243,7 +2243,7 @@ static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware
hdr = (void *)&firmware->data[0];
if (memcmp(hdr->magic, "WMDR", 4) != 0) {
- cs_dsp_err(dsp, "%s: invalid coefficient magic\n", file);
+ cs_dsp_err(dsp, "%s: not a WMDR file\n", file);
goto out_fw;
}
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-06 15:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-06 15:00 [PATCH] firmware: cs_dsp: Replace the obscure "invalid magic" messages Richard Fitzgerald
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®