mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Marcos Paulo de Souza <mpdesouza@suse.com>,
	Chris Down <chris@chrisdown.name>,
	Naveen Kumar Chaudhary <naveen.osdev@gmail.com>,
	printk@lists.linux.dev, linux-kernel@vger.kernel.org,
	Petr Mladek <pmladek@suse.com>
Subject: [PATCH v6 09/16] printk: Do not quietly ignore adding entry for a preferred console when there is no space
Date: Fri,  6 Nov 2026 18:19:45 +0100	[thread overview]
Message-ID: <20261106171952.207909-10-pmladek@suse.com> (raw)
In-Reply-To: <20261106171952.207909-1-pmladek@suse.com>

It is hard to imagine that anyone would want to add more than 8 preferred
consoles. But never say never. And do not ignore new entries quietly.

Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Chris Down <chris@chrisdown.name>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
 kernel/printk/printk.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 60923b997e4f..1eb542a321a5 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2578,8 +2578,10 @@ static int add_or_update_preferred_console(unsigned int i,
 	struct preferred_console *pc;
 	bool is_new_entry = false;
 
-	if (i >= MAX_PREFERRED_CONSOLES)
+	if (i >= MAX_PREFERRED_CONSOLES) {
+		pr_err_once("Reached maximal number of preferred consoles.\n");
 		return -E2BIG;
+	}
 
 	pc = &preferred_consoles[i];
 
-- 
2.56.0


  parent reply	other threads:[~2026-11-06 17:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 17:19 [PATCH v6 00/16] printk: Clean up preferred console handling Petr Mladek
2026-11-06 17:19 ` [PATCH v6 01/16] printk: Rename struct console_cmdline to preferred_console Petr Mladek
2026-11-06 17:19 ` [PATCH v6 02/16] printk: Rename preferred_console to preferred_dev_console Petr Mladek
2026-11-06 17:19 ` [PATCH v6 03/16] printk: Cleanup _braille_(un)register_console() wrappers Petr Mladek
2026-11-06 17:19 ` [PATCH v6 04/16] printk: Separate code for adding/updating preferred console metadata Petr Mladek
2026-11-06 17:19 ` [PATCH v6 05/16] printk: Do not accept an empty name or devname as a preferred console Petr Mladek
2026-11-06 17:19 ` [PATCH v6 06/16] printk: Prefer the console either via name or devname exclusively Petr Mladek
2026-11-06 17:19 ` [PATCH v6 07/16] printk: Check that index is not defined when a console is preferred via devname Petr Mladek
2026-11-06 17:19 ` [PATCH v6 08/16] printk: Ensure consistent name and devname when updating preferred console Petr Mladek
2026-11-06 17:19 ` Petr Mladek [this message]
2026-11-06 17:19 ` [PATCH v6 10/16] printk: Allow to debug misuse of add_or_update_preferred_console() Petr Mladek
2026-11-06 17:19 ` [PATCH v6 11/16] console/braille: Lock console->setup() call during the registration Petr Mladek
2026-11-06 17:19 ` [PATCH v6 12/16] printk: Separate code for enabling console Petr Mladek
2026-11-06 17:19 ` [PATCH v6 13/16] printk: Try to register each console as Braille first Petr Mladek
2026-11-06 17:19 ` [PATCH v6 14/16] printk: Do not set Braille console as preferred_console Petr Mladek
2026-11-06 17:19 ` [PATCH v6 15/16] printk: Modify try_enable_default_console() to return error/success Petr Mladek
2026-11-06 17:19 ` [PATCH v6 16/16] printk: Try enable preferred consoles only when there are any Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106171952.207909-10-pmladek@suse.com \
    --to=pmladek@suse.com \
    --cc=chris@chrisdown.name \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpdesouza@suse.com \
    --cc=naveen.osdev@gmail.com \
    --cc=printk@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®