mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Eikmeyer" <dev@deq.rocks>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: <asahi@lists.linux.dev>, <brcm80211-dev-list.pdl@broadcom.com>,
	<brcm80211@lists.linux.dev>, <dberlin@dberlin.org>,
	<frankyl@broadcom.com>, <gustavoars@kernel.org>, <j@jannau.net>,
	<kees@kernel.org>, <kvalo@kernel.org>,
	<linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-wireless@vger.kernel.org>, <marcan@marcan.st>,
	<meuleman@broadcom.com>, <michael.reeves077@gmail.com>,
	<pieterpg@broadcom.com>, <vanhoefm@gmail.com>
Subject: Re: [PATCH 05/13] wifi: brcmfmac: Negotiate PCIe mailbox transport with firmware
Date: Fri, 6 Nov 2026 19:18:26 +0100	[thread overview]
Message-ID: <20261106191826.4ddb997a@kait2en-mbp15-1> (raw)
In-Reply-To: <1a1b1ef4b20.2873.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>

On Fri, 06 Nov 2026 18:36:52 +0100
Arend van Spriel <arend.vanspriel@broadcom.com> wrote:

> Sorry, you lost me there. What is the relation between the patch in
> this subject and D3 ack.

Hi Arend,

D3_INFORM and D3_ACK are mailbox messages, and 05 changes how they are
exchanged. Without 05 brcmfmac writes D3_INFORM to the TCM mailbox
and our cursed Apple 4377 firmware on the 9,1 doesn't read it.

That is why I mentioned the D3 ACK timeout handling patch. I
submitted that because I was sure the firmware wouldn't send it.
But actually the transport was broken.

https://lore.kernel.org/all/20261001085308.1688049-1-dev@deq.rocks/

which was superseded by Sebastian's patch here:

https://lore.kernel.org/linux-wireless/20260915-brcmfmac-bcm43752-suspend-fix-v2-1-1bd84914998b@collabora.com/

So probably for addressing Sebastian's issue this needs to stay
anyways. My memory served me wrong. I just read that his device is not
an Apple product, but his patch incidentally worked around the same
problem. Sorry if i was causing unneccessary noise. 

Andre

  reply	other threads:[~2026-11-06 18:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 13:43 [PATCH 00/13] wifi: brcmfmac: Add BCM4388 support Michael Reeves via B4 Relay
2026-09-25 13:43 ` [PATCH 01/13] wifi: brcmfmac: pcie: Report the detected chip ID to the bus Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 02/13] wifi: brcmfmac: Match complete firmware capability names Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 03/13] wifi: brcmfmac: Fall back to RSSI-only default join preferences Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 04/13] wifi: brcmfmac: Support newer PCIe core startup and interrupts Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 05/13] wifi: brcmfmac: Negotiate PCIe mailbox transport with firmware Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-11-06 14:36     ` André Eikmeyer
2026-11-06 17:36       ` Arend van Spriel
2026-11-06 18:18         ` André Eikmeyer [this message]
2026-09-25 13:43 ` [PATCH 06/13] wifi: brcmfmac: Load signed PCIe firmware images Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 07/13] wifi: brcmfmac: Use event_msgs_ext for event masks Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 08/13] wifi: brcmfmac: Handle larger firmware band lists Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 09/13] wifi: brcmfmac: Accept newer BSS information versions Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 10/13] wifi: brcmfmac: Support versioned scan parameter layouts Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 11/13] wifi: brcmfmac: Support versioned join requests Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 12/13] wifi: brcmfmac: Handle extended PMK command payloads Michael Reeves via B4 Relay
2026-11-03 13:58   ` Arend van Spriel
2026-09-25 13:43 ` [PATCH 13/13] wifi: brcmfmac: Add BCM4388 support Michael Reeves via B4 Relay
2026-11-02 20:36   ` Janne Grunau
2026-11-03 13:58   ` Arend van Spriel
2026-10-07 12:54 ` [PATCH 00/13] " Arend van Spriel
2026-11-01 19:27 ` Arend van Spriel
2026-11-02 20:46   ` Janne Grunau
2026-11-03 13:51     ` Arend van Spriel
2026-11-02  0:42 ` Neal Gompa
2026-11-02 16:58   ` Arend van Spriel
2026-11-05 21:44     ` Neal Gompa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106191826.4ddb997a@kait2en-mbp15-1 \
    --to=dev@deq.rocks \
    --cc=arend.vanspriel@broadcom.com \
    --cc=asahi@lists.linux.dev \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=dberlin@dberlin.org \
    --cc=frankyl@broadcom.com \
    --cc=gustavoars@kernel.org \
    --cc=j@jannau.net \
    --cc=kees@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=meuleman@broadcom.com \
    --cc=michael.reeves077@gmail.com \
    --cc=pieterpg@broadcom.com \
    --cc=vanhoefm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®