mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] nvme-pci: add NO_NS_DESC_LIST quirk for SSSTC CL1 SSDs
@ 2026-11-05 13:45 Chengyuan He
  2026-11-06 10:53 ` Christoph Hellwig
  2026-11-06 16:32 ` Keith Busch
  0 siblings, 2 replies; 4+ messages in thread
From: Chengyuan He @ 2026-11-05 13:45 UTC (permalink / raw)
  To: linux-nvme
  Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
	linux-kernel, Chengyuan He

The SSSTC CL1 series (PCI ID 1e95:9100, e.g. CL1-3D128-Q11, a Silicon
Motion SM2263XT based OEM drive shipped in Dell laptops) reports NVMe
version 1.3 but fails the Namespace Identification Descriptor list
(CNS 03h) with Invalid Field in Command:

  nvme nvme1: Identify Descriptors failed (nsid=1, status=0x2)

nvme_scan_ns() gives up on the namespace when nvme_identify_ns_descs()
fails, so no block device is created even though the controller is live
and namespace 1 is otherwise fully functional.

The failure was reproduced with the latest vendor firmware 22301119
(Dell package NJV53, A09) as well as with an older third-party firmware.
The drive reports an all-zero NGUID and EUI64, so skipping the
descriptor list loses no identifiers.

The generic Silicon Motion SM2263 entry (126f:2263) already carries
NVME_QUIRK_NO_NS_DESC_LIST. This drive reports 126f:2263 only as its
subsystem ID, so that entry does not match it.

Add NVME_QUIRK_NO_NS_DESC_LIST for 1e95:9100 as well.

Tested on 7.0.14 by booting with nvme.quirks=1e95:9100:no_ns_desc_list,
after which the namespace shows up and I/O works.

Signed-off-by: Chengyuan He <channing1ne@gmail.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index eade0b1..af19c75 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -4282,6 +4282,8 @@ static const struct pci_device_id nvme_id_table[] = {
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x10ec, 0x5765), /* TEAMGROUP MP33 2TB SSD */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x1e95, 0x9100), /* SSSTC CL1 series */
+		.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0061),
 		.driver_data = NVME_QUIRK_DMA_ADDRESS_BITS_48, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0065),

base-commit: c64d9b2c1f4fd1d8fa52dab37b48428a99c4d58d
--
2.54.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme-pci: add NO_NS_DESC_LIST quirk for SSSTC CL1 SSDs
  2026-11-05 13:45 [PATCH] nvme-pci: add NO_NS_DESC_LIST quirk for SSSTC CL1 SSDs Chengyuan He
@ 2026-11-06 10:53 ` Christoph Hellwig
  2026-11-06 16:32 ` Keith Busch
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2026-11-06 10:53 UTC (permalink / raw)
  To: Chengyuan He
  Cc: linux-nvme, Keith Busch, Jens Axboe, Christoph Hellwig,
	Sagi Grimberg, linux-kernel, Chengyuan He

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme-pci: add NO_NS_DESC_LIST quirk for SSSTC CL1 SSDs
  2026-11-05 13:45 [PATCH] nvme-pci: add NO_NS_DESC_LIST quirk for SSSTC CL1 SSDs Chengyuan He
  2026-11-06 10:53 ` Christoph Hellwig
@ 2026-11-06 16:32 ` Keith Busch
  2026-11-07  1:43   ` Chengyuan He
  1 sibling, 1 reply; 4+ messages in thread
From: Keith Busch @ 2026-11-06 16:32 UTC (permalink / raw)
  To: Chengyuan He
  Cc: linux-nvme, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
	linux-kernel, Chengyuan He

On Thu, Nov 05, 2026 at 10:45:26PM +0900, Chengyuan He wrote:
> Signed-off-by: Chengyuan He <channing1ne@gmail.com>

Your sign off email doesn't match the patch's author. Which one should
be used?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme-pci: add NO_NS_DESC_LIST quirk for SSSTC CL1 SSDs
  2026-11-06 16:32 ` Keith Busch
@ 2026-11-07  1:43   ` Chengyuan He
  0 siblings, 0 replies; 4+ messages in thread
From: Chengyuan He @ 2026-11-07  1:43 UTC (permalink / raw)
  To: Keith Busch
  Cc: linux-nvme, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel

On Fri, Nov 06, 2026 at 09:32:35AM -0700, Keith Busch wrote:
> On Thu, Nov 05, 2026 at 10:45:26PM +0900, Chengyuan He wrote:
> > Signed-off-by: Chengyuan He <channing1ne@gmail.com>
>
> Your sign off email doesn't match the patch's author. Which one should
> be used?

Sorry about that, please use channing1ne@gmail.com. Both addresses
belong to the same Gmail account, which was renamed recently, and
Gmail's SMTP server rewrote the From: header to the old address.

If it's easier for you, I can resend the patch with an in-body From:
line instead.

Thanks,
Chengyuan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-07  1:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-05 13:45 [PATCH] nvme-pci: add NO_NS_DESC_LIST quirk for SSSTC CL1 SSDs Chengyuan He
2026-11-06 10:53 ` Christoph Hellwig
2026-11-06 16:32 ` Keith Busch
2026-11-07  1:43   ` Chengyuan He

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®