mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Pengfei <ljdlns1987@gmail.com>
To: rostedt@goodmis.org, mhiramat@kernel.org
Cc: mathieu.desnoyers@efficios.com, mark.rutland@arm.com,
	corbet@lwn.net, skhan@linuxfoundation.org,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
	zhangbo56@xiaomi.com, lipengfei28@xiaomi.com
Subject: Re: [RFC PATCH v7 02/10] trace: use the stackmap from the ftrace stack recording path
Date: Sat,  7 Nov 2026 13:38:58 +0800	[thread overview]
Message-ID: <20261107053858.3070072-1-lipengfei28@xiaomi.com> (raw)
In-Reply-To: <20261103193421.63f4454a@gandalf.local.home>

From: Pengfei Li <lipengfei28@xiaomi.com>

On Tue, 3 Nov 2026 19:34:21 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> FYI, the tracing subsystem requires starting subjects with capital letters:
> 
>   trace: Use the stackmap from the ftrace stack recording path

Will fix for all patches, and use the "tracing:" prefix that the rest of
kernel/trace uses.

> Also, did you use AI for this? Most of the comments are useless, and sound
> like they come from AI.

Yes. I used an AI assistant to help draft a substantial portion of the
code, nearly all of the comments and changelogs, and most of the test
programs. The design decisions are mine, and I checked the test results
and went through every version, but I should have trimmed the comments
myself before sending. Many of them were added in response to automated
review findings rather than to explain the code, and they stayed. I
should also have stated the AI use from the first version.

For v8 I am going through every comment in the series, removing the ones
that only restate the code or the review history, and keeping only what
the code cannot say. v8 carries Assisted-by tags, and the cover letter
says what the assistant was used for.

The rest of your comments on this patch will be in v8: a record_stackmap()
helper with a stub, the depth check before loading the map, a named enum,
the tracefs setup moved into a helper, a stub for
stackmap_mark_init_failed() so the #ifdef goes away, and the comments you
pointed out removed.

Thanks,
Pengfei Li

  reply	other threads:[~2026-11-07  5:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12  8:37 [RFC PATCH v7 00/10] trace: stack trace deduplication for ftrace ring buffer Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 01/10] trace: add lock-free stackmap for stack trace deduplication Li Pengfei
2026-11-03 22:49   ` Steven Rostedt
2026-11-07  5:39     ` Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 02/10] trace: use the stackmap from the ftrace stack recording path Li Pengfei
2026-11-04  0:34   ` Steven Rostedt
2026-11-07  5:38     ` Li Pengfei [this message]
2026-09-12  8:37 ` [RFC PATCH v7 03/10] trace: add stackmap statistics interface Li Pengfei
2026-11-04  0:36   ` Steven Rostedt
2026-09-12  8:37 ` [RFC PATCH v7 04/10] trace: add stackmap binary export Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 05/10] trace: make the stackmap capacity settable on the kernel command line Li Pengfei
     [not found]   ` <20260912085841.48E7B1F00893@smtp.kernel.org>
2026-09-14  6:08     ` Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 06/10] Documentation: tracing: document the ftrace stackmap Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 07/10] tools/tracing: add a parser for the stackmap binary export Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 08/10] selftests/ftrace: add a stackmap basic functionality test Li Pengfei
     [not found]   ` <20260912090213.C77861F00893@smtp.kernel.org>
2026-09-14  6:08     ` Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 09/10] selftests/ftrace: add a stackmap reset and binary ABI test Li Pengfei
2026-09-12  8:37 ` [RFC PATCH v7 10/10] selftests/ftrace: add a stackmap instance gating test Li Pengfei
2026-10-13  2:03 ` [RFC PATCH v7 00/10] trace: stack trace deduplication for ftrace ring buffer Li Pengfei
2026-11-04  0:44   ` Steven Rostedt
2026-11-07  5:40     ` Li Pengfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107053858.3070072-1-lipengfei28@xiaomi.com \
    --to=ljdlns1987@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lipengfei28@xiaomi.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=skhan@linuxfoundation.org \
    --cc=zhangbo56@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®