[PATCH 0/2] i3c: remove redundant pm_runtime_dont_use_autosuspend() calls

[PATCH 0/2] i3c: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
Joshua Crofts (2):
      i3c: dw: remove redundant pm_runtime_dont_use_autosuspend() calls
      i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

 drivers/i3c/master/dw-i3c-master.c  | 2 --
 drivers/i3c/master/svc-i3c-master.c | 2 --
 2 files changed, 4 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261107-dont-use-autosuspend-i3c-d05c16c18c80

Best regards,
-- 
Joshua Crofts

[PATCH 1/2] i3c: dw: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/i3c/master/dw-i3c-master.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index d1119f203d1b..f8fed797e0e4 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -1776,7 +1776,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 		pm_runtime_put_noidle(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 
 	return ret;
 }
@@ -1792,7 +1791,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *master)
 
 	pm_runtime_disable(master->dev);
 	pm_runtime_set_suspended(master->dev);
-	pm_runtime_dont_use_autosuspend(master->dev);
 }
 EXPORT_SYMBOL_GPL(dw_i3c_common_remove);
 

-- 
2.56.0

[PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/i3c/master/svc-i3c-master.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index e700392f0801..9b845b2955be 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
 	return 0;
 
 rpm_disable:
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_put_noidle(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);
@@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
 
 	i3c_master_unregister(&master->base);
 
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 }
 

-- 
2.56.0

Re: [PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

On Sat, 07 Nov 2026 12:06:24 +0100
Joshua Crofts <crofts@kernel.org> wrote:

> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
> 
> Remove the redundant function calls.
> 
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---
>  drivers/i3c/master/svc-i3c-master.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index e700392f0801..9b845b2955be 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
>  	return 0;
>  
>  rpm_disable:
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);
>  	pm_runtime_put_noidle(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	pm_runtime_set_suspended(&pdev->dev);
> @@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
>  
>  	i3c_master_unregister(&master->base);
>  
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  }
>  
> 

Okay, after reading Sashiko's review it seems that this patch won't
be as straight forward as I thought. I'm thinking of manually
suspending the device in the remove() function or just removing
dont_use_autosuspend() from the probe error path. Any thoughts?

--
Kind regards,
Joshua Crofts