[PATCH] check-uapi: avoid truncating the failure count in the exit status

[PATCH] check-uapi: avoid truncating the failure count in the exit status

[Hamdy Abou El Anein]

From: Hamdy Abou El Anein <hamdy.aea@protonmail.com>

check_uapi_files() returns the number of failed header checks as its
status. Bash truncates this to eight bits, so 256 failed checks return
zero. run() then treats the ABI check as successful. With -q, the error
diagnostics are hidden as well.

Return a boolean status instead, while keeping the full failure count
in the existing summary.

Tested the complete CLI with fixture Git trees containing 0, 1, 255,
256, 257 and 512 removed headers, plus -j 1 and -q. The 256- and
512-failure cases now exit 1 instead of 0.

AI assistance: ChatGPT/Codex identified the issue and prepared the
change, commit message and executable regression tests.

Fixes: 1f7f31bf7202 ("check-uapi: Introduce check-uapi.sh")
Signed-off-by: Hamdy Abou El Anein <hamdy.aea@protonmail.com>
---
The regression fixtures use a minimal headers_install Makefile and
an abidiff stand-in that only supplies --version. Actual removed-header
checks, Git archives and the CLI exit path are exercised; no ABI
comparison is invoked for these removed headers.

 scripts/check-uapi.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/check-uapi.sh b/scripts/check-uapi.sh
index c8beec588..93095a5b8 100755
--- a/scripts/check-uapi.sh
+++ b/scripts/check-uapi.sh
@@ -295,7 +295,7 @@ check_uapi_files() {
 			"$total" "$ARCH"
 	fi
 
-	return "$failed"
+	return "$((failed != 0))"
 }
 
 # Check an individual file for UAPI compatibility

base-commit: d48723711bae9b8cdc56719c448ba42fef28cbee
-- 
2.56.0