* Re: [PATCH v3] drm/xe: Remove unused xe_vm_restart tracepoint
2026-11-08 6:04 ` [PATCH v3] drm/xe: Remove unused xe_vm_restart tracepoint Torra Sowmya
@ 2026-11-08 7:17 ` Sowmya Torra
2026-11-08 7:53 ` [PATCH v4] drm/xe: Remove unused xe_vm_restart and xe_vma_flush tracepoints Torra Sowmya
1 sibling, 0 replies; 3+ messages in thread
From: Sowmya Torra @ 2026-11-08 7:17 UTC (permalink / raw)
To: matthew.brost, thomas.hellstrom, rodrigo.vivi
Cc: airlied, simona, intel-xe, dri-devel, linux-kernel, outreachy,
rostedt, julianbraha, julia.lawall
Hi everyone,
I missed Steven’s request to combine this with the xe_vma_flush
removal before sending v3. Please hold off on applying this version.
I’m testing a combined revision and will send it shortly.
Sorry for the extra email.
Best regards,
Sowmya
On Sun, Nov 8, 2026 at 11:35 AM Torra Sowmya <sowmyatorra@gmail.com> wrote:
>
> Commit f3e9b1f43458 ("drm/xe: Remove async worker and rework sync
> binds") removed the call to trace_xe_vm_restart(), but left the
> event definition behind.
>
> Remove the unused definition from xe_trace_bo.h to avoid generating
> code and data for an event that has no callers.
>
> With the tested x86-64 configuration, size reports a reduction of
> 436 bytes in xe_trace_bo.o, from 20262 to 19826 bytes: 140 bytes
> in text and 296 bytes in data.
>
> Fixes: f3e9b1f43458 ("drm/xe: Remove async worker and rework sync binds")
> Signed-off-by: Torra Sowmya <sowmyatorra@gmail.com>
> ---
> Changes in v3:
> - Add the Fixes tag.
>
> Changes in v2:
> - Document the measured object-size reduction.
>
> drivers/gpu/drm/xe/xe_trace_bo.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_trace_bo.h
> index 86323cf3be2c..fa91dd2b2174 100644
> --- a/drivers/gpu/drm/xe/xe_trace_bo.h
> +++ b/drivers/gpu/drm/xe/xe_trace_bo.h
> @@ -228,11 +228,6 @@ DEFINE_EVENT(xe_vm, xe_vm_cpu_bind,
> TP_ARGS(vm)
> );
>
> -DEFINE_EVENT(xe_vm, xe_vm_restart,
> - TP_PROTO(struct xe_vm *vm),
> - TP_ARGS(vm)
> -);
> -
> DEFINE_EVENT(xe_vm, xe_vm_rebind_worker_enter,
> TP_PROTO(struct xe_vm *vm),
> TP_ARGS(vm)
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v4] drm/xe: Remove unused xe_vm_restart and xe_vma_flush tracepoints
2026-11-08 6:04 ` [PATCH v3] drm/xe: Remove unused xe_vm_restart tracepoint Torra Sowmya
2026-11-08 7:17 ` Sowmya Torra
@ 2026-11-08 7:53 ` Torra Sowmya
1 sibling, 0 replies; 3+ messages in thread
From: Torra Sowmya @ 2026-11-08 7:53 UTC (permalink / raw)
To: matthew.brost, thomas.hellstrom, rodrigo.vivi
Cc: airlied, simona, intel-xe, dri-devel, linux-kernel, outreachy,
rostedt, julianbraha, julia.lawall
Commit f3e9b1f43458 ("drm/xe: Remove async worker and rework sync
binds") removed the calls to trace_xe_vm_restart() and
trace_xe_vma_flush(), but left both event definitions behind.
Remove the unused definitions from xe_trace_bo.h to avoid
generating code and data for events with no remaining callers.
With the tested x86-64 configuration, size reports a reduction of
888 bytes in xe_trace_bo.o, from 20262 to 19374 bytes: 296 bytes
in text and 592 bytes in data.
Fixes: f3e9b1f43458 ("drm/xe: Remove async worker and rework sync binds")
Signed-off-by: Torra Sowmya <sowmyatorra@gmail.com>
---
Changes in v4:
- Combine the xe_vm_restart and xe_vma_flush removals as requested
by Steven. This replaces the separate patches for these events.
- Report the measured combined object-size reduction.
Changes in v3:
- Add the Fixes tag.
Changes in v2:
- Document the measured object-size reduction.
drivers/gpu/drm/xe/xe_trace_bo.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_trace_bo.h
index 86323cf3be2c..a6802f6d3a01 100644
--- a/drivers/gpu/drm/xe/xe_trace_bo.h
+++ b/drivers/gpu/drm/xe/xe_trace_bo.h
@@ -115,11 +115,6 @@ DECLARE_EVENT_CLASS(xe_vma,
__entry->end, __entry->ptr)
)
-DEFINE_EVENT(xe_vma, xe_vma_flush,
- TP_PROTO(struct xe_vma *vma),
- TP_ARGS(vma)
-);
-
DEFINE_EVENT(xe_vma, xe_vma_pagefault,
TP_PROTO(struct xe_vma *vma),
TP_ARGS(vma)
@@ -228,11 +223,6 @@ DEFINE_EVENT(xe_vm, xe_vm_cpu_bind,
TP_ARGS(vm)
);
-DEFINE_EVENT(xe_vm, xe_vm_restart,
- TP_PROTO(struct xe_vm *vm),
- TP_ARGS(vm)
-);
-
DEFINE_EVENT(xe_vm, xe_vm_rebind_worker_enter,
TP_PROTO(struct xe_vm *vm),
TP_ARGS(vm)
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread