[PATCH] PCI: mt7621: Fix reset control leak on PHY initialization failure

[PATCH] PCI: mt7621: Fix reset control leak on PHY initialization failure

[Sreeraj S Kurup]

The PCIe port initialization code acquires a reset control handle using
of_reset_control_get_exclusive(). However, when PHY initialization or
power-on fails, the port is removed from the PCIe port list without
releasing the acquired reset control handle.

Since the reset control cleanup iterates over the remaining ports in
the list, the removed port's reset control handle is never released.

Call reset_control_put() before removing the failed port from the list
to ensure that the reset control resource is properly released.

Fixes a resource leak on PCIe PHY initialization failure.

Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
---
 drivers/pci/controller/pcie-mt7621.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index 01ead2f92e87..1dcaa2829609 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -361,6 +361,7 @@ static int mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
 		err = mt7621_pcie_init_port(port);
 		if (err) {
 			dev_err(dev, "initializing port %d failed\n", slot);
+			reset_control_put(port->pcie_rst);
 			list_del(&port->list);
 		}
 	}
-- 
2.55.0

Re: [PATCH] PCI: mt7621: Fix reset control leak on PHY initialization failure

[Sergio Paracuellos]

On Sun, Nov 1, 2026 at 8:02 AM Sreeraj S Kurup
<sreekuttan2156239@gmail.com> wrote:
>
> The PCIe port initialization code acquires a reset control handle using
> of_reset_control_get_exclusive(). However, when PHY initialization or
> power-on fails, the port is removed from the PCIe port list without
> releasing the acquired reset control handle.
>
> Since the reset control cleanup iterates over the remaining ports in
> the list, the removed port's reset control handle is never released.
>
> Call reset_control_put() before removing the failed port from the list
> to ensure that the reset control resource is properly released.
>
> Fixes a resource leak on PCIe PHY initialization failure.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
> ---
>  drivers/pci/controller/pcie-mt7621.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos

Re: [PATCH] PCI: mt7621: Fix reset control leak on PHY initialization failure

[Manivannan Sadhasivam]

On Sun, 01 Nov 2026 07:01:21 +0000, Sreeraj S Kurup wrote:
> The PCIe port initialization code acquires a reset control handle using
> of_reset_control_get_exclusive(). However, when PHY initialization or
> power-on fails, the port is removed from the PCIe port list without
> releasing the acquired reset control handle.
> 
> Since the reset control cleanup iterates over the remaining ports in
> the list, the removed port's reset control handle is never released.
> 
> [...]

Applied, thanks!

[1/1] PCI: mt7621: Fix reset control leak on PHY initialization failure
      commit: 1973b0f280bb753e0810346a9377766c38230752

Best regards,
-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH] PCI: mt7621: Fix reset control leak on PHY initialization failure

[Sreeraj S Kurup]

Hi,

Thanks for applying the patch!

Best regards,
Sreeraj