From: Svyatoslav Ryhel <clamor95@gmail.com>
To: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Lee Jones" <lee@kernel.org>,
"Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, mfd@lists.linux.dev
Subject: [PATCH v1 2/4] mfd: max8907: Add ADC client support
Date: Sun, 8 Nov 2026 11:56:32 +0200 [thread overview]
Message-ID: <20261108095634.100517-3-clamor95@gmail.com> (raw)
In-Reply-To: <20261108095634.100517-1-clamor95@gmail.com>
The Maxim MAX8907 has an 8-channel ADC at a fixed location. Add client
support for it along with its regmap and interrupts.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/mfd/max8907.c | 74 +++++++++++++++++++++++++++++++++++++
include/linux/mfd/max8907.h | 53 ++++++++++++++++++++++++++
2 files changed, 127 insertions(+)
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index 826d7768fd8d0..86579729111ee 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -113,6 +113,48 @@ static const struct regmap_config max8907_regmap_rtc_config = {
.cache_type = REGCACHE_MAPLE,
};
+static bool max8907_adc_is_volatile_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case MAX8907_REG_TSC_STA_INT:
+ case MAX8907_REG_AUX1_MSB ... MAX8907_REG_TDIE_LSB:
+ return true;
+ default:
+ return false;
+ }
+}
+
+static bool max8907_adc_is_precious_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case MAX8907_REG_TSC_STA_INT:
+ return true;
+ default:
+ return false;
+ }
+}
+
+static bool max8907_adc_is_writeable_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case MAX8907_REG_TSC_STA_INT:
+ case MAX8907_REG_AUX1_MSB ... MAX8907_REG_TDIE_LSB:
+ return false;
+ default:
+ return true;
+ }
+}
+
+static const struct regmap_config max8907_regmap_adc_config = {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .volatile_reg = max8907_adc_is_volatile_reg,
+ .precious_reg = max8907_adc_is_precious_reg,
+ .writeable_reg = max8907_adc_is_writeable_reg,
+ .max_register = MAX8907_REG_TDIE_MEASURE,
+ .cache_type = REGCACHE_MAPLE,
+};
+
static const struct regmap_irq max8907_chg_irqs[] = {
{ .reg_offset = 0, .mask = 1 << 0, },
{ .reg_offset = 0, .mask = 1 << 1, },
@@ -175,6 +217,20 @@ static const struct regmap_irq_chip max8907_rtc_irq_chip = {
.num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
};
+static const struct regmap_irq max8907_adc_irqs[] = {
+ { .reg_offset = 0, .mask = BIT(0), },
+ { .reg_offset = 0, .mask = BIT(1), },
+};
+
+static const struct regmap_irq_chip max8907_adc_irq_chip = {
+ .name = "max8907 adc",
+ .status_base = MAX8907_REG_TSC_STA_INT,
+ .mask_base = MAX8907_REG_TSC_INT_MASK,
+ .num_regs = 1,
+ .irqs = max8907_adc_irqs,
+ .num_irqs = ARRAY_SIZE(max8907_adc_irqs),
+};
+
static int max8907_power_off(struct sys_off_data *data)
{
struct max8907 *max8907 = data->cb_data;
@@ -220,6 +276,18 @@ static int max8907_i2c_probe(struct i2c_client *i2c)
return dev_err_probe(dev, PTR_ERR(max8907->regmap_rtc),
"RTC regmap init failed\n");
+ max8907->i2c_adc = devm_i2c_new_dummy_device(dev, i2c->adapter, MAX8907_ADC_I2C_ADDR);
+ if (IS_ERR(max8907->i2c_adc))
+ return PTR_ERR(max8907->i2c_adc);
+
+ i2c_set_clientdata(max8907->i2c_adc, max8907);
+
+ max8907->regmap_adc = devm_regmap_init_i2c(max8907->i2c_adc,
+ &max8907_regmap_adc_config);
+ if (IS_ERR(max8907->regmap_adc))
+ return dev_err_probe(dev, PTR_ERR(max8907->regmap_adc),
+ "ADC regmap init failed\n");
+
ret = devm_regmap_add_irq_chip(dev, max8907->regmap_gen, max8907->i2c_gen->irq,
IRQF_ONESHOT | IRQF_SHARED, -1, &max8907_chg_irq_chip,
&max8907->irqc_chg);
@@ -238,6 +306,12 @@ static int max8907_i2c_probe(struct i2c_client *i2c)
if (ret)
return dev_err_probe(dev, ret, "Failed to add rtc irq chip\n");
+ ret = devm_regmap_add_irq_chip(dev, max8907->regmap_adc, max8907->i2c_gen->irq,
+ IRQF_ONESHOT | IRQF_SHARED, -1, &max8907_adc_irq_chip,
+ &max8907->irqc_adc);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to add adc irq chip\n");
+
ret = devm_mfd_add_devices(dev, -1, max8907_cells, ARRAY_SIZE(max8907_cells),
NULL, 0, NULL);
if (ret)
diff --git a/include/linux/mfd/max8907.h b/include/linux/mfd/max8907.h
index 35b2ede54f856..cf304afc782d6 100644
--- a/include/linux/mfd/max8907.h
+++ b/include/linux/mfd/max8907.h
@@ -153,6 +153,51 @@
#define MAX8907_REG_MPL_CNTL 0x1E
/* ADC and Touch Screen Controller register map */
+#define MAX8907_REG_TSC_STA_INT 0x00
+#define MAX8907_REG_TSC_INT_MASK 0x01
+#define MAX8907_REG_TSC_CNFG1 0x02
+#define MAX8907_REG_TSC_CNFG2 0x03
+#define MAX8907_REG_TSC_CNFG3 0x04
+#define MAX8907_REG_ADC_RES_CNFG1 0x06
+#define MAX8907_REG_ADC_AVG_CNFG1 0x07
+#define MAX8907_REG_ADC_ACQ_CNFG1 0x08
+#define MAX8907_REG_ADC_ACQ_CNFG2 0x09
+#define MAX8907_REG_ADC_SCHED 0x10
+#define MAX8907_REG_X_MSB 0x50
+#define MAX8907_REG_X_LSB 0x51
+#define MAX8907_REG_Y_MSB 0x52
+#define MAX8907_REG_Y_LSB 0x53
+#define MAX8907_REG_Z1_MSB 0x54
+#define MAX8907_REG_Z1_LSB 0x55
+#define MAX8907_REG_Z2_MSB 0x56
+#define MAX8907_REG_Z2_LSB 0x57
+#define MAX8907_REG_AUX1_MSB 0x60
+#define MAX8907_REG_AUX1_LSB 0x61
+#define MAX8907_REG_AUX2_MSB 0x62
+#define MAX8907_REG_AUX2_LSB 0x63
+#define MAX8907_REG_VCHG_MSB 0x64
+#define MAX8907_REG_VCHG_LSB 0x65
+#define MAX8907_REG_VBBATT_MSB 0x66
+#define MAX8907_REG_VBBATT_LSB 0x67
+#define MAX8907_REG_VMBATT_MSB 0x68
+#define MAX8907_REG_VMBATT_LSB 0x69
+#define MAX8907_REG_ISNS_MSB 0x6A
+#define MAX8907_REG_ISNS_LSB 0x6B
+#define MAX8907_REG_THM_MSB 0x6C
+#define MAX8907_REG_THM_LSB 0x6D
+#define MAX8907_REG_TDIE_MSB 0x6E
+#define MAX8907_REG_TDIE_LSB 0x6F
+
+#define MAX8907_REG_AUX1_MEASURE 0xC0
+#define MAX8907_REG_AUX2_MEASURE 0xC8
+#define MAX8907_REG_VCHG_MEASURE 0xD0
+#define MAX8907_REG_VBBATT_MEASURE 0xD8
+#define MAX8907_REG_VMBATT_MEASURE 0xE0
+#define MAX8907_REG_ISNS_MEASURE 0xE8
+#define MAX8907_REG_THM_MEASURE 0xF0
+#define MAX8907_REG_TDIE_MEASURE 0xF8
+
+/* Regulator stride */
#define MAX8907_CTL 0
#define MAX8907_SEQCNT 1
#define MAX8907_VOUT 2
@@ -165,6 +210,8 @@
#define MAX8907_MASK_OUT5V_ENSRC 0x0E
#define MAX8907_MASK_OUT5V_EN 0x01
#define MAX8907_MASK_POWER_OFF 0x40
+#define MAX8907_MASK_RST_CFG_INT_REF_EN 0x01
+#define MAX8907_MASK_NREF_OK 0x10
/* Regulator IDs */
#define MAX8907_MBATT 0
@@ -225,6 +272,9 @@ enum {
MAX8907_IRQ_RTC_ALARM1 = 0,
MAX8907_IRQ_RTC_ALARM0,
+
+ MAX8907_IRQ_TSC_STICK = 0,
+ MAX8907_IRQ_TSC_NSTICK,
};
struct regmap_irq_chips_data;
@@ -234,11 +284,14 @@ struct max8907 {
struct mutex irq_lock;
struct i2c_client *i2c_gen;
struct i2c_client *i2c_rtc;
+ struct i2c_client *i2c_adc;
struct regmap *regmap_gen;
struct regmap *regmap_rtc;
+ struct regmap *regmap_adc;
struct regmap_irq_chip_data *irqc_chg;
struct regmap_irq_chip_data *irqc_on_off;
struct regmap_irq_chip_data *irqc_rtc;
+ struct regmap_irq_chip_data *irqc_adc;
};
#endif
--
2.53.0
next prev parent reply other threads:[~2026-11-08 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 9:56 [PATCH v1 0/4] iio: adc: Add support for MAX8907 ADC cell Svyatoslav Ryhel
2026-11-08 9:56 ` [PATCH v1 1/4] regulator: dt-bindings: maxim,max8907: Document io-channel-cells property Svyatoslav Ryhel
2026-11-08 10:40 ` Mark Brown
2026-11-08 9:56 ` Svyatoslav Ryhel [this message]
2026-11-08 9:56 ` [PATCH v1 3/4] iio: adc: Add support for MAX8907 ADC cell Svyatoslav Ryhel
2026-11-08 9:56 ` [PATCH v1 4/4] mfd: max8907: Add " Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108095634.100517-3-clamor95@gmail.com \
--to=clamor95@gmail.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®