From: Svyatoslav Ryhel <clamor95@gmail.com>
To: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Lee Jones" <lee@kernel.org>,
"Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, mfd@lists.linux.dev
Subject: [PATCH v1 3/4] iio: adc: Add support for MAX8907 ADC cell
Date: Sun, 8 Nov 2026 11:56:33 +0200 [thread overview]
Message-ID: <20261108095634.100517-4-clamor95@gmail.com> (raw)
In-Reply-To: <20261108095634.100517-1-clamor95@gmail.com>
The MAX8907 PMIC has a dedicated ADC cell, which provides 8 ADC channels
with information about different parts of the power system, including the
battery, charger/plug, jack and thermal readings.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/iio/adc/Kconfig | 10 ++
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/max8907-adc.c | 195 ++++++++++++++++++++++++++++++++++
3 files changed, 206 insertions(+)
create mode 100644 drivers/iio/adc/max8907-adc.c
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index a802d8ee4dd9c..25b094575a5d3 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1166,6 +1166,16 @@ config MAX77541_ADC
To compile this driver as a module, choose M here:
the module will be called max77541-adc.
+config MAX8907_ADC
+ tristate "Maxim MAX8907 ADC driver"
+ depends on MFD_MAX8907
+ help
+ Say yes here to build support for 8 channel 12-bit ADC
+ interface found in the Maxim MAX8907 PMIC.
+
+ To compile this driver as a module, choose M here:
+ the module will be called max8907-adc.
+
config MAX9611
tristate "Maxim max9611/max9612 ADC driver"
depends on I2C
diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile
index 9e82c21dbd374..12247d8e0aa29 100644
--- a/drivers/iio/adc/Makefile
+++ b/drivers/iio/adc/Makefile
@@ -99,6 +99,7 @@ obj-$(CONFIG_MAX14001) += max14001.o
obj-$(CONFIG_MAX34408) += max34408.o
obj-$(CONFIG_MAX40080) += max40080.o
obj-$(CONFIG_MAX77541_ADC) += max77541-adc.o
+obj-$(CONFIG_MAX8907_ADC) += max8907-adc.o
obj-$(CONFIG_MAX9611) += max9611.o
obj-$(CONFIG_MCP320X) += mcp320x.o
obj-$(CONFIG_MCP3422) += mcp3422.o
diff --git a/drivers/iio/adc/max8907-adc.c b/drivers/iio/adc/max8907-adc.c
new file mode 100644
index 0000000000000..d1acb5bc95c15
--- /dev/null
+++ b/drivers/iio/adc/max8907-adc.c
@@ -0,0 +1,195 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/iio/iio.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/mfd/max8907.h>
+#include <linux/platform_device.h>
+#include <linux/property.h>
+#include <linux/regmap.h>
+
+/* MAX8907_ADC_RES_CNFG1 */
+#define RES_AUX1 BIT(7)
+#define RES_AUX2 BIT(6)
+#define RES_VCHG BIT(5)
+#define RES_VBBATT BIT(4)
+#define RES_VMBATT BIT(3)
+#define RES_ISNS BIT(2)
+#define RES_THM BIT(1)
+#define RES_TDIE BIT(0)
+
+/* MAX8907_ADC_AVG_CNFG1 */
+#define AVG_AUX1_EN BIT(7)
+#define AVG_AUX2_EN BIT(6)
+#define AVG_VCHG_EN BIT(5)
+#define AVG_VBBATT_EN BIT(4)
+#define AVG_VMBATT_EN BIT(3)
+#define AVG_ISNS_EN BIT(2)
+#define AVG_THM_EN BIT(1)
+#define AVG_TDIE_EN BIT(0)
+
+/* MAX8907_ADC_ACQ_CNFG1 */
+#define T_ACQ_AUX1 BIT(7)
+#define T_ACQ_AUX2 BIT(5)
+#define T_ACQ_VCHG BIT(3)
+#define T_ACQ_VBBATT BIT(1)
+
+/* MAX8907_ADC_ACQ_CNFG2 */
+#define T_ACQ_VMBATT BIT(6)
+#define T_ACQ_ISNS BIT(4)
+#define T_ACQ_THM BIT(2)
+#define T_ACQ_TDIE BIT(0)
+
+/* MAX8907_ADC_SCHED */
+#define AUTOSCH_ENABLE BIT(1)
+#define AUTOSCH_TIME BIT(0)
+
+#define TO_REG(n) ((n) & 0xff)
+#define TO_MEASURE(n) (((n) >> 8) & 0xff)
+
+enum {
+ TDIE, THM, ISNS, VMBATT, VBBATT, VCHG, AUX2, AUX1
+};
+
+static const u32 max8907_default_ref[] = {
+ 4096, 4096, 4096, 8192, 8192, 8192, 2500, 4096
+};
+
+#define MAX8907_CHAN(_type, _idname, _datasheet_name) { \
+ .type = (_type), \
+ .address = MAX8907_REG_##_idname##_MSB | \
+ MAX8907_REG_##_idname##_MEASURE << 8, \
+ .indexed = 1, \
+ .channel = (_idname), \
+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
+ BIT(IIO_CHAN_INFO_SCALE), \
+ .scan_index = (_idname), \
+ .scan_type = { \
+ .format = IIO_SCAN_FORMAT_UNSIGNED_INT, \
+ .realbits = 12, \
+ .storagebits = 16, \
+ .endianness = IIO_CPU, \
+ }, \
+ .datasheet_name = (_datasheet_name), \
+}
+
+static const struct iio_chan_spec max8907_adc_channels[] = {
+ MAX8907_CHAN(IIO_VOLTAGE, TDIE, "tdiode"),
+ MAX8907_CHAN(IIO_VOLTAGE, THM, "thermistor"),
+ MAX8907_CHAN(IIO_CURRENT, ISNS, "isense"),
+ MAX8907_CHAN(IIO_VOLTAGE, VMBATT, "vmbatt"),
+ MAX8907_CHAN(IIO_VOLTAGE, VBBATT, "vbbatt"),
+ MAX8907_CHAN(IIO_VOLTAGE, VCHG, "vcharge"),
+ MAX8907_CHAN(IIO_VOLTAGE, AUX2, "aux2"),
+ MAX8907_CHAN(IIO_VOLTAGE, AUX1, "aux1"),
+};
+
+static int max8907_adc_read(struct iio_dev *indio_dev,
+ struct iio_chan_spec const *chan,
+ int *val, int *val2, long mask)
+{
+ struct regmap **regmap = iio_priv(indio_dev);
+ unsigned char data[2] = { 0, 0 };
+ int ret;
+
+ switch (mask) {
+ case IIO_CHAN_INFO_RAW:
+ ret = regmap_write(*regmap, TO_MEASURE(chan->address), 0);
+ if (ret)
+ return ret;
+
+ ret = regmap_bulk_read(*regmap, TO_REG(chan->address), data, 2);
+ if (ret)
+ return ret;
+
+ *val = ((data[0] << 8) | data[1]) >> 4;
+
+ return IIO_VAL_INT;
+
+ case IIO_CHAN_INFO_SCALE:
+ *val = max8907_default_ref[chan->channel];
+ *val2 = chan->scan_type.realbits;
+
+ return IIO_VAL_FRACTIONAL_LOG2;
+
+ default:
+ return -EINVAL;
+ }
+}
+
+static const struct iio_info max8907_adc_info = {
+ .read_raw = &max8907_adc_read,
+};
+
+static int max8907_adc_init(struct regmap *regmap)
+{
+ u32 value;
+ int ret;
+
+ /* Enable internal voltage reference. Exact purpose of bits is not known. */
+ ret = regmap_update_bits(regmap, MAX8907_REG_TSC_CNFG1, GENMASK(1, 0), BIT(1));
+ if (ret)
+ return ret;
+
+ /* Check for internal reference IRQ */
+ ret = regmap_read_poll_timeout(regmap, MAX8907_REG_TSC_STA_INT, value,
+ !(value & MAX8907_MASK_NREF_OK), 0, 1000);
+ if (ret)
+ return ret;
+
+ /* Enable ADC scheduler with 1 second interval */
+ ret = regmap_update_bits(regmap, MAX8907_REG_ADC_SCHED,
+ AUTOSCH_ENABLE | AUTOSCH_TIME, AUTOSCH_TIME);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static int max8907_adc_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct max8907 *max8907 = dev_get_drvdata(dev->parent);
+ struct iio_dev *indio_dev;
+ struct regmap **regmap;
+ int ret;
+
+ indio_dev = devm_iio_device_alloc(dev, sizeof(*regmap));
+ if (!indio_dev)
+ return -ENOMEM;
+
+ regmap = iio_priv(indio_dev);
+
+ *regmap = max8907->regmap_adc;
+
+ indio_dev->modes = INDIO_DIRECT_MODE;
+ indio_dev->channels = max8907_adc_channels;
+ indio_dev->num_channels = ARRAY_SIZE(max8907_adc_channels);
+ indio_dev->name = dev_name(dev);
+ indio_dev->info = &max8907_adc_info;
+
+ iio_device_set_parent(indio_dev, dev->parent);
+
+ /* Enable ADCREF */
+ ret = regmap_set_bits(max8907->regmap_gen, MAX8907_REG_RESET_CNFG,
+ MAX8907_MASK_RST_CFG_INT_REF_EN);
+ if (ret)
+ return ret;
+
+ ret = max8907_adc_init(max8907->regmap_adc);
+ if (ret)
+ return ret;
+
+ return devm_iio_device_register(dev, indio_dev);
+}
+
+static struct platform_driver max8907_adc_driver = {
+ .driver.name = "max8907-adc",
+ .probe = max8907_adc_probe,
+};
+module_platform_driver(max8907_adc_driver);
+
+MODULE_ALIAS("platform:max8907-adc");
+MODULE_AUTHOR("Svyatoslav Ryhel <clamor95@gmail.com>");
+MODULE_DESCRIPTION("MAX8907 ADC driver");
+MODULE_LICENSE("GPL");
--
2.53.0
next prev parent reply other threads:[~2026-11-08 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 9:56 [PATCH v1 0/4] " Svyatoslav Ryhel
2026-11-08 9:56 ` [PATCH v1 1/4] regulator: dt-bindings: maxim,max8907: Document io-channel-cells property Svyatoslav Ryhel
2026-11-08 10:40 ` Mark Brown
2026-11-08 9:56 ` [PATCH v1 2/4] mfd: max8907: Add ADC client support Svyatoslav Ryhel
2026-11-08 9:56 ` Svyatoslav Ryhel [this message]
2026-11-08 9:56 ` [PATCH v1 4/4] mfd: max8907: Add ADC cell Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108095634.100517-4-clamor95@gmail.com \
--to=clamor95@gmail.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®