From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: tglx@kernel.org, mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH v2 0/4] selftests/futex: Fix flaky futex_wait and futex_waitv tests
Date: Sun, 8 Nov 2026 09:49:48 -0500 [thread overview]
Message-ID: <20261108144952.1531160-1-mathieu.desnoyers@efficios.com> (raw)
Hi Thomas, Peter,
The futex_wait and futex_waitv selftests assume that a waiter thread
blocks within 10ms, and that the main thread wakes it in time. Under
load, both assumptions fail. With the built-in locktorture, the tests
failed in 0.5% to 1% of the runs in 8-CPU VMs. Repeated runs of
futex_waitv also run out of System V shared memory segments.
These four patches fix both problems:
1 Let the futex_waitv() helper take no timeout.
2 Retry the wake in futex_wait until the waiter has returned, instead
of sleeping a fixed time.
3 Do the same in futex_waitv, and join its waiter.
4 Remove the shared memory segments that the tests create.
How this was developed
======================
An LLM coding assistant wrote these patches and their messages, under
my direction and review.
Changes since v1
================
- v1 was patch 2 alone. It retried the wake for up to 5s, and gave the
waiter a timeout of 10s. Both bounds were timing assumptions too. In
v2, the main thread retries until the waiter has returned from
futex_wait(), and the waiter waits without a timeout.
- New patches 1, 3 and 4.
Based on v7.4-rc1, 6628e7d4c6b2.
v1: https://lore.kernel.org/all/20261108142309.1527337-1-mathieu.desnoyers@efficios.com/
Mathieu Desnoyers (4):
selftests/futex: Let futex_waitv() take no timeout
selftests/futex: Retry the wake in futex_wait instead of sleeping
selftests/futex: Retry the wake in futex_waitv instead of sleeping
selftests/futex: Remove the shared memory segments of the futex tests
.../selftests/futex/functional/futex_wait.c | 59 +++++++++++++------
.../selftests/futex/functional/futex_waitv.c | 52 +++++++++++-----
.../selftests/futex/include/futex2test.h | 14 +++--
3 files changed, 86 insertions(+), 39 deletions(-)
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.47.3
next reply other threads:[~2026-11-08 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 14:49 Mathieu Desnoyers [this message]
2026-11-08 14:49 ` [PATCH v2 1/4] selftests/futex: Let futex_waitv() take no timeout Mathieu Desnoyers
2026-11-08 14:49 ` [PATCH v2 2/4] selftests/futex: Retry the wake in futex_wait instead of sleeping Mathieu Desnoyers
2026-11-08 14:49 ` [PATCH v2 3/4] selftests/futex: Retry the wake in futex_waitv " Mathieu Desnoyers
2026-11-08 14:49 ` [PATCH v2 4/4] selftests/futex: Remove the shared memory segments of the futex tests Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108144952.1531160-1-mathieu.desnoyers@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=andrealmeid@igalia.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®