From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: tglx@kernel.org, mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH v2 1/4] selftests/futex: Let futex_waitv() take no timeout
Date: Sun, 8 Nov 2026 09:49:49 -0500 [thread overview]
Message-ID: <20261108144952.1531160-2-mathieu.desnoyers@efficios.com> (raw)
In-Reply-To: <20261108144952.1531160-1-mathieu.desnoyers@efficios.com>
The futex_waitv() helper of futex2test.h copies the caller's timeout
into a struct __kernel_timespec. It dereferences the pointer without a
check, so a caller cannot pass NULL. The syscall takes NULL as no
timeout.
Pass NULL to the syscall when the caller passes NULL. The futex_waitv
tests use this in a later patch, to wait until they are woken.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
tools/testing/selftests/futex/include/futex2test.h | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/futex/include/futex2test.h b/tools/testing/selftests/futex/include/futex2test.h
index 53e88b60ac6d..a4616b6edcff 100644
--- a/tools/testing/selftests/futex/include/futex2test.h
+++ b/tools/testing/selftests/futex/include/futex2test.h
@@ -68,12 +68,16 @@ struct futex32_numa {
static inline int futex_waitv(volatile struct futex_waitv *waiters, unsigned long nr_waiters,
unsigned long flags, struct timespec *timo, clockid_t clockid)
{
- struct __kernel_timespec ts = {
- .tv_sec = timo->tv_sec,
- .tv_nsec = timo->tv_nsec,
- };
+ struct __kernel_timespec ts, *tsp = NULL;
- return syscall(__NR_futex_waitv, waiters, nr_waiters, flags, &ts, clockid);
+ /* No timeout: wait until woken. */
+ if (timo) {
+ ts.tv_sec = timo->tv_sec;
+ ts.tv_nsec = timo->tv_nsec;
+ tsp = &ts;
+ }
+
+ return syscall(__NR_futex_waitv, waiters, nr_waiters, flags, tsp, clockid);
}
/*
--
2.47.3
next prev parent reply other threads:[~2026-11-08 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 14:49 [PATCH v2 0/4] selftests/futex: Fix flaky futex_wait and futex_waitv tests Mathieu Desnoyers
2026-11-08 14:49 ` Mathieu Desnoyers [this message]
2026-11-08 14:49 ` [PATCH v2 2/4] selftests/futex: Retry the wake in futex_wait instead of sleeping Mathieu Desnoyers
2026-11-08 14:49 ` [PATCH v2 3/4] selftests/futex: Retry the wake in futex_waitv " Mathieu Desnoyers
2026-11-08 14:49 ` [PATCH v2 4/4] selftests/futex: Remove the shared memory segments of the futex tests Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108144952.1531160-2-mathieu.desnoyers@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=andrealmeid@igalia.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®