* [PATCH v2] iio: adc: ad_sigma_delta: use __free(kfree) for temporary buffers
@ 2026-11-08 20:15 Adi Kadušić
0 siblings, 0 replies; only message in thread
From: Adi Kadušić @ 2026-11-08 20:15 UTC (permalink / raw)
To: Jonathan Cameron, Nuno Sá, Michael Hennerich
Cc: David Lechner, Andy Shevchenko, linux, linux-iio, linux-kernel,
Adi Kadušić
Replace manual kfree() calls with the __free(kfree) cleanup attribute.
No functional change.
Signed-off-by: Adi Kadušić <kadusicadi1@gmail.com>
---
Changes in v2:
- Keep reset_length/size declarations in ad_sd_reset() as they were,
only declare buf with __free(kfree) at its allocation (Andy)
v1: https://lore.kernel.org/linux-iio/20261108013328.125069-1-kadusicadi1@gmail.com/T/#u
drivers/iio/adc/ad_sigma_delta.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index 119ddc5a13e2..934c9965c69b 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -205,19 +205,15 @@ int ad_sd_reset(struct ad_sigma_delta *sigma_delta)
{
unsigned int reset_length = sigma_delta->info->num_resetclks;
unsigned int size;
- u8 *buf;
- int ret;
size = BITS_TO_BYTES(reset_length);
- buf = kcalloc(size, sizeof(*buf), GFP_KERNEL);
+ u8 *buf __free(kfree) = kcalloc(size, sizeof(*buf), GFP_KERNEL);
if (!buf)
return -ENOMEM;
memset(buf, 0xff, size);
- ret = spi_write(sigma_delta->spi, buf, size);
- kfree(buf);
- return ret;
+ return spi_write(sigma_delta->spi, buf, size);
}
EXPORT_SYMBOL_NS_GPL(ad_sd_reset, "IIO_AD_SIGMA_DELTA");
@@ -249,7 +245,6 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta
{
bool pending_event;
unsigned int data_read_len = BITS_TO_BYTES(sigma_delta->info->num_resetclks);
- u8 *data;
struct spi_transfer t[] = {
{
.len = 1,
@@ -317,7 +312,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta
* shorter than the reset procedure.
*/
- data = kzalloc(data_read_len + 1, GFP_KERNEL);
+ u8 *data __free(kfree) = kzalloc(data_read_len + 1, GFP_KERNEL);
if (!data)
return -ENOMEM;
@@ -340,11 +335,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta
memset(data + 2, 0xff, data_read_len - 1);
spi_message_add_tail(&t[1], &m);
- ret = spi_sync_locked(sigma_delta->spi, &m);
-
- kfree(data);
-
- return ret;
+ return spi_sync_locked(sigma_delta->spi, &m);
}
int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-08 20:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-08 20:15 [PATCH v2] iio: adc: ad_sigma_delta: use __free(kfree) for temporary buffers Adi Kadušić
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®